Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

y2makepot - extract translatable string from Qt designer *.ui files #169

Merged
merged 4 commits into from May 17, 2022
Merged

y2makepot - extract translatable string from Qt designer *.ui files #169

merged 4 commits into from May 17, 2022

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented May 16, 2022

Problem

Solution

  • Lets add support Qt designer files, fortunately these are XML so the solution is similar to YaST the control file support.

Testing

  • Tested manually

y2makepot finds the texts in libyui-qt:

#: src/QStyleEditor.ui:26
msgid "&Apply"
msgstr ""

#: src/QStyleEditor.ui:36
msgid "Auto Apply"
msgstr ""

#: src/QStyleEditor.ui:66
msgid "&Load File"
msgstr ""

Links

See also related libyui/libyui#75

@lslezak lslezak mentioned this pull request May 16, 2022
Closed
@shundhammer shundhammer mentioned this pull request May 16, 2022
Closed
@lslezak
Copy link
Member Author

lslezak commented May 17, 2022

Ah, it reads the TEXTDOMAIN file from the top level directory while libyui/libyui#75 adds that file into the libyui-qt subdirectory... I'll fix that.

@shundhammer shundhammer mentioned this pull request May 17, 2022
Merged
shundhammer
shundhammer approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested + LGTM.

@shundhammer
Copy link
Contributor

See also libyui/libyui#76

shundhammer
shundhammer approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 94b6d24 into master May 17, 2022
@lslezak lslezak deleted the gettext_ui_files branch May 17, 2022 12:42
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #37 successfully finished
✔️ Created OBS submit request #977765

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #21 successfully finished
✔️ Created IBS submit request #276666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shundhammer shundhammer shundhammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lslezak @shundhammer @yast-bot