New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix maintainer substitution #62
Conversation
@@ -1,4 +1,10 @@ | |||
------------------------------------------------------------------- | |||
Tue Sep 23 09:25:35 UTC 2014 - jreidinger@suse.com | |||
|
|||
- prevent crash for non standard maintainer file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's MAINTAINER
file, just to not confuse somebody...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, will change ti
LGTM, but I'm not sure if we want this in SLE12, maybe we should merge it after branching SLE12... |
Depends on the fact whether we have MAINTAINER file in SLE 12 branch or not. |
@kobliha as I do not increase version it can get to SLE12 only if package is submitted, but it do not break osc build, so not problem |
Huh?? That only delays any problems, which is worse. |
Moreover, you do increase the version to yast2-devtools-3.1.25. |
I mean increase in modules where I modify MAINTAINER file, not this one. |
Anyway, this PR is fixing a problem but you haven't stated the problem. As I see it, the problem is:
There is no "crash". Am I right? |
I now have the problem mvidner explains (working with master on 13.1). |
LGTM now. |
@mvidner thanks |
No description provided.