Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maintainer substitution #62

Merged
merged 4 commits into from Oct 8, 2014
Merged

Conversation

jreidinger
Copy link
Member

No description provided.

@@ -1,4 +1,10 @@
-------------------------------------------------------------------
Tue Sep 23 09:25:35 UTC 2014 - jreidinger@suse.com

- prevent crash for non standard maintainer file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's MAINTAINER file, just to not confuse somebody...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will change ti

@lslezak
Copy link
Member

lslezak commented Oct 1, 2014

LGTM, but I'm not sure if we want this in SLE12, maybe we should merge it after branching SLE12...

@kobliha
Copy link
Member

kobliha commented Oct 1, 2014

Depends on the fact whether we have MAINTAINER file in SLE 12 branch or not.

@jreidinger
Copy link
Member Author

@kobliha as I do not increase version it can get to SLE12 only if package is submitted, but it do not break osc build, so not problem

@mvidner
Copy link
Member

mvidner commented Oct 1, 2014

I do not increase version it can get to SLE12 only if package is submitted, but it do not break osc build, so not problem

Huh?? That only delays any problems, which is worse.

@mvidner
Copy link
Member

mvidner commented Oct 1, 2014

as I do not increase version

Moreover, you do increase the version to yast2-devtools-3.1.25.

@jreidinger
Copy link
Member Author

Moreover, you do increase the version to yast2-devtools-3.1.25.

I mean increase in modules where I modify MAINTAINER file, not this one.

@mvidner
Copy link
Member

mvidner commented Oct 6, 2014

Anyway, this PR is fixing a problem but you haven't stated the problem. As I see it, the problem is:

configure will contain "Deprecated file. Use osc maintainer yast2-kdump instead." so the command will actually be run at ./configure time.

There is no "crash". Am I right?

@jreidinger
Copy link
Member Author

@lslezak as you are the one who report problem, you should answer @mvidner question.

@mvidner I do not see any crash in jenkins, which is the most important for me.

@aschnell
Copy link
Member

aschnell commented Oct 7, 2014

I now have the problem mvidner explains (working with master on 13.1).

@mvidner
Copy link
Member

mvidner commented Oct 8, 2014

LGTM now.

jreidinger added a commit that referenced this pull request Oct 8, 2014
@jreidinger jreidinger merged commit 250bbc2 into master Oct 8, 2014
@jreidinger jreidinger deleted the fix_maintainer_substitution branch October 8, 2014 12:36
@jreidinger
Copy link
Member Author

@mvidner thanks

@lslezak
Copy link
Member

lslezak commented Oct 14, 2014

@lslezak as you are the one who report problem, you should answer @mvidner question.

Oops, overlooked this. The problem is when the osc call returns multiline string, it breaks the Makefile file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants