Fix displaying a custom proposal set in AY #980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter the installation proposals (in the Installation Settings screen) according to the AutoYaST profile even before tab switching
The filtering code was only used after a tab change (in
switch_to_tab
), here apply it also for the initial display.Manual Test
I tested the fix with a profile that limited the proposals to software and language:
(full profile at https://gist.github.com/mvidner/909181a348483fd367ab2c689880a293#file-minimal-sle-15-proposalmodulebug-sw-lang-xml)
Screenshots of a Tabbed Proposal, Before and After
This test used a stock
control.xml
file which has Installation Settings show two tabs, Overview and Expert.Screenshots of a Non-Tabbed Proposal, Before and After
This test used a modified
control.xml
that limited the proposal set to software, timezone, language, presenting them without tabs.