From 16c49dc51730566cfcd346080b863910b069b9a3 Mon Sep 17 00:00:00 2001 From: Josef Reidinger Date: Fri, 9 Dec 2022 13:00:30 +0100 Subject: [PATCH] changes from review --- src/lib/kdump/kdump_calibrator.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/lib/kdump/kdump_calibrator.rb b/src/lib/kdump/kdump_calibrator.rb index d4406b8..6d149f4 100644 --- a/src/lib/kdump/kdump_calibrator.rb +++ b/src/lib/kdump/kdump_calibrator.rb @@ -162,8 +162,9 @@ def system def run_kdumptool out = Yast::SCR.Execute(Yast::Path.new(".target.bash_output"), kdumptool_cmd) if out["exit"].zero? - # ensure that fadump is set to unsupported as fadump can be missing in output - # and it means fadump not supported ( as oppose to high mem which is always in output) + # If fadump is missing from output, it means it isn't supported (unlike + # high mem, which is always in output). Thus, let's set fadump related + # values to zero before parsing the kdumptool output @max_fadump = @min_fadump = @default_fadump = 0 proposal = parse(out["stdout"]) # Populate @min_low, @max_low, @total_memory, etc.