Skip to content

Commit

Permalink
Merge pull request #1 from varkoly/master
Browse files Browse the repository at this point in the history
I think it can be merged
  • Loading branch information
jsuchome committed Nov 28, 2012
2 parents 1e43fc1 + c7d9ea7 commit 243972e
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 18 deletions.
6 changes: 6 additions & 0 deletions package/yast2-mail.changes
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Thu Nov 8 11:30:50 UTC 2012 - varkoly@suse.com

- bnc#784659 - remove SuSEconfig calls from yast2-mail
- bnc#782048 - postfix uses /sbin/conf.d

------------------------------------------------------------------- -------------------------------------------------------------------
Thu Mar 29 15:24:06 CEST 2012 - jsuchome@suse.cz Thu Mar 29 15:24:06 CEST 2012 - jsuchome@suse.cz


Expand Down
22 changes: 7 additions & 15 deletions src/Mail.ycp
Expand Up @@ -50,15 +50,15 @@
global symbol mta = nil; global symbol mta = nil;


/** /**
* If true, don't run SuSEconfig or restart the services. * If true, don't restart the services.
* Autoinstall uses this to do all in one place. * Autoinstall uses this to do all in one place.
*/ */
global boolean write_only = false; global boolean write_only = false;


boolean create_config = false; boolean create_config = false;
/** /**
* If MAIL_CREATE_CONFIG is not yes, the user * If MAIL_CREATE_CONFIG is not yes, the user
* does not want SuSEconfig to modify sendmail.cf/main.cf. * does not want us to modify sendmail.cf/main.cf.
* So we will warn him before setting it to yes. * So we will warn him before setting it to yes.
* @return Is it yes? * @return Is it yes?
*/ */
Expand Down Expand Up @@ -1092,19 +1092,11 @@ a fixed format to be readable by YaST. For details, see
* Part of Write. * Part of Write.
* @return success * @return success
*/ */
global define boolean WriteSuSEconfig () ``{ global define boolean WriteConfig () ``{
//run SuSEconfig with the necessary modules
// TODO other modules using FROM_HEADER?
integer ret = 0; integer ret = 0;
if (mta == `sendmail) if (mta == `postfix)
{
ret = (integer)
SCR::Execute(.target.bash,"/sbin/SuSEconfig --module sendmail");
}
else if (mta == `postfix)
{ {
ret = (integer) ret = (integer) SCR::Execute(.target.bash, "/usr/sbin/config.postfix");
SCR::Execute(.target.bash, "/usr/sbin/SuSEconfig.postfix");
} }
else else
{ {
Expand All @@ -1114,7 +1106,7 @@ a fixed format to be readable by YaST. For details, see
if (ret != 0) if (ret != 0)
{ {
// Translators: error message // Translators: error message
Report::Error (_("Error running SuSEconfig.")); Report::Error (_("Error running config.postfix"));
return false; return false;
} }
return true; return true;
Expand Down Expand Up @@ -1216,7 +1208,7 @@ a fixed format to be readable by YaST. For details, see
if (! write_only) if (! write_only)
{ {
// Translators: progress label // Translators: progress label
stages = add (stages, [ _("Running SuSEconfig"), WriteSuSEconfig ]); stages = add (stages, [ _("Running Config Postfix"), WriteConfig ]);


// Translators: progress label // Translators: progress label
stages = add (stages, [ _("Restarting services"), WriteServices ]); stages = add (stages, [ _("Restarting services"), WriteServices ]);
Expand Down
2 changes: 1 addition & 1 deletion src/MailServer.ycp
Expand Up @@ -43,7 +43,7 @@ global boolean proposal_valid = false;


/** /**
* Write only, used during autoinstallation. * Write only, used during autoinstallation.
* Don't run services and SuSEconfig, it's all done at one place. * Don't run services, it's all done at one place.
*/ */
global boolean write_only = false; global boolean write_only = false;


Expand Down
2 changes: 1 addition & 1 deletion src/ui.ycp
Expand Up @@ -76,7 +76,7 @@ define symbol ReadDialog () ``{
was_ok = Popup::ContinueCancel (sformat (_("The setting %1 is turned off. You have was_ok = Popup::ContinueCancel (sformat (_("The setting %1 is turned off. You have
probably modified the configuration files directly. probably modified the configuration files directly.
If you continue, it will be turned on and If you continue, it will be turned on and
SuSEconfig will overwrite manual changes. Config Postfix will overwrite manual changes.
"), setting)); "), setting));
} }
} }
Expand Down
2 changes: 1 addition & 1 deletion src/widgets.ycp
Expand Up @@ -653,7 +653,7 @@ define list Choices_delivery_mode () ``{
`item (`id (`dm_cyrus), _("To Cyrus IMAP Server")), `item (`id (`dm_cyrus), _("To Cyrus IMAP Server")),
// TODO: should check whether cyrus-imapd is installed. // TODO: should check whether cyrus-imapd is installed.
// And show the choice only if it is. // And show the choice only if it is.
// But SuSEconfig.postfix falls back to local if it's not, so OK // But config.postfix falls back to local if it's not, so OK
]; ];
} }


Expand Down

0 comments on commit 243972e

Please sign in to comment.