Merge pull request #933 from yast/network-ng-fix-name-validation

network ng: fix name validation

src/lib/y2network/widgets/interface_name.rb

@@ -30,6 +30,7 @@ def initialize(settings)
         textdomain "network"
 
         @settings = settings
+        @old_name = @settings.name
       end
 
       def label
@@ -57,7 +58,7 @@ def items
       end
 
       def validate
-        if @settings.name_exists?(value)
+        if @old_name != value && @settings.name_exists?(value)
           Yast::Popup.Error(
             format(_("Configuration name %s already exists.\nChoose a different one."), value)
           )

test/y2network/widgets/interface_name_test.rb

@@ -52,12 +52,26 @@
       expect(subject.validate).to be false
     end
 
-    it "fails for already used names" do
-      allow(subject).to receive(:value).and_return valid_name
-      allow(Yast::NetworkInterfaces).to receive(:List).and_return [valid_name]
+    context "when the name is already used" do
+      before do
+        allow(subject).to receive(:value).and_return valid_name
+        allow(Yast::NetworkInterfaces).to receive(:List).and_return [valid_name]
+      end
 
-      expect(Yast::UI).to receive(:SetFocus)
-      expect(subject.validate).to be false
+      context "if the name was changed" do
+        let(:valid_name) { "eth1" }
+
+        it "fails" do
+          expect(Yast::UI).to receive(:SetFocus)
+          expect(subject.validate).to be false
+        end
+      end
+
+      context "if the name was not changed" do
+        it "passes" do
+          expect(subject.validate).to eq(true)
+        end
+      end
     end
   end
 

test/y2network/widgets/interface_naming_test.rb

@@ -30,7 +30,8 @@
   let(:builder) do
     instance_double(
       Y2Network::InterfaceConfigBuilder,
-      interface: interface
+      interface: interface,
+      name:      "eth0"
     )
   end