From e84e6212efb2b80534ddc9e0e2b71909426145e3 Mon Sep 17 00:00:00 2001
From: Michal Filka <mfilka@suse.cz>
Date: Mon, 6 Jun 2016 12:48:48 +0200
Subject: [PATCH] Fixed setting firewall.

ProtectByFirewall method allways sets modified flag for firewall module.
So when called unconditionally it causes rewriting of network
configuration even when not needed (no zone changed).
---
 src/modules/SuSEFirewall4Network.rb | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/src/modules/SuSEFirewall4Network.rb b/src/modules/SuSEFirewall4Network.rb
index bc2189cbe..bd2858533 100644
--- a/src/modules/SuSEFirewall4Network.rb
+++ b/src/modules/SuSEFirewall4Network.rb
@@ -218,26 +218,29 @@ def AnyInterfacesHandledByFirewall
     # @return	[Boolean] if successful
     def ProtectByFirewall(interface, zone, protect_status)
       # Adding protection
-      if protect_status == true
-        Builtins.y2milestone(
-          "Enabling firewall because of '%1' interface",
-          interface
-        )
-        SuSEFirewall.AddInterfaceIntoZone(interface, zone)
+      if protect_status
+        log.info("Enabling firewall because of '#{interface}' interface")
+
+        if !SuSEFirewall.GetInterfacesInZone(zone).include?(interface)
+          SuSEFirewall.AddInterfaceIntoZone(interface, zone)
+        end
+
         SuSEFirewall.SetEnableService(true)
         SuSEFirewall.SetStartService(true)
-        # Removing protection
+      # Removing protection
       else
         # removing from all known zones
-        Builtins.foreach(SuSEFirewall.GetKnownFirewallZones) do |remove_from_zone|
+        zones = SuSEFirewall.GetKnownFirewallZones.select do |zone|
+          SuSEFirewall.GetInterfacesInZone(zone).include?(interface)
+        end
+        zones.each do |remove_from_zone|
           SuSEFirewall.RemoveInterfaceFromZone(interface, remove_from_zone)
         end
         # if there are no other interfaces in configuration, stop firewall
         # and remove it from boot process
         if !AnyInterfacesHandledByFirewall()
-          Builtins.y2milestone(
-            "Disabling firewall, no interfaces are protected."
-          )
+          log.info("Disabling firewall, no interfaces are protected."
+)
           SuSEFirewall.SetEnableService(false)
           SuSEFirewall.SetStartService(false)
         end