Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved mock of NetworkService actions #837

Merged
merged 2 commits into from Jun 14, 2019
Merged

Improved mock of NetworkService actions #837

merged 2 commits into from Jun 14, 2019

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Jun 14, 2019 •
edited

Mock and test the force restart option

@coveralls
Copy link

coveralls commented Jun 14, 2019 •
edited

Coverage Status

Coverage increased (+0.07%) to 51.126% when pulling 13e24b3 on mocked_force_restart_service into a80fe64 on master.

mchf
mchf approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@mchf mchf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teclator teclator merged commit 417a8ea into master Jun 14, 2019
@teclator teclator deleted the mocked_force_restart_service branch June 14, 2019 13:22
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #70 successfully finished
✔️ Created OBS submit request #709987

@teclator teclator mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

@mchf mchf mchf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@teclator @coveralls @yast-bot @jreidinger @mchf