Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network ng write connection config #875

Merged
merged 25 commits into from Jul 19, 2019

Conversation

@imobachgs
Copy link
Contributor

commented Jul 9, 2019

This PR adds support to write ifcfg-* files for network interfaces (the so-called ConfigurationConfig objects in the new data model). At this point in time, only Ethernet and Wireless connections are supported.

Note: there is a problem when writing the IP address. I am working on a fix.

imobachgs added some commits Jul 8, 2019

Rename InterfaceFile#name to InterfaceFile#interface
* Resolves a conflict between InterfaceFile#name and the NAME parameter.
@coveralls

This comment has been minimized.

Copy link

commented Jul 9, 2019

Coverage Status

Coverage increased (+0.5%) to 62.572% when pulling ec625ab on network-ng-write-connection-config into 0ba57a0 on network-ng.

@imobachgs imobachgs marked this pull request as ready for review Jul 9, 2019

instance_double(
Y2Network::Sysconfig::InterfaceFile, save: nil, clean: nil
)
end

This comment has been minimized.

Copy link
@jreidinger

jreidinger Jul 10, 2019

Member

I would really feel more confident if we can simply switch SCR here and operate on real files. So we see what is real changes.

This comment has been minimized.

Copy link
@imobachgs

imobachgs Jul 10, 2019

Author Contributor

We rely on Y2Network::Sysconfig::InterfaceFile in which unit tests we switch SCR and operate on real files. See

change_scr_root(scr_root, &example)
.

imobachgs added some commits Jul 10, 2019

@jreidinger jreidinger referenced this pull request Jul 11, 2019
@imobachgs imobachgs referenced this pull request Jul 12, 2019

imobachgs added some commits Jul 12, 2019

Fix IP address handling in InterfaceFile
* Unit tests are using a real file now.

@teclator teclator force-pushed the network-ng-write-connection-config branch from 6d073af to dc06c7d Jul 19, 2019

Merge branch 'network-ng' into network-ng-write-connection-config
* network-ng: (38 commits)
  change from review
  Fixes based on CR.
  Bump version and update changes file
  Drops an unneeded require
  Add some documentation improvements/fixes
  Fix indentantion issues
  Update from code review
  Documentation fix in Y2Network::ConfigReader
  Documentation fix in Y2Network::Interface
  Documentation fix in Y2Network::FakeInterface
  Documentation fix in Y2Network::ConfigWriter
  use new type everywhere
  make type for interface config builder mandatory
  Added FICON interface type
  Added missing s390 interfaces
  Refresh the table should also refresh the buttons
  Merge the config with aliases always
  Add aliases to the builder sysconfig devmap
  Added missing type
  Dropped unused method
  ...
doc/network-ng.md Outdated Show resolved Hide resolved
{Y2Network::Sysconfig::DNSReader}, {Y2Network::Sysconfig::InterfacesReader} and
{Y2Network::Sysconfig::ConnectionConfigReader} are involved in reading the configuration. The logic
to read the configuration for a connection (e.g., `ifcfg-eth0`, `ifcfg-wlan0`, etc.) is implemented
in a set of smaller classes (one for each time of connection) under

This comment has been minimized.

Copy link
@jreidinger

jreidinger Jul 19, 2019

Member

maybe mention here InterfaceType class that is used for that smaller class as delimeter.

imobachgs added some commits Jul 19, 2019

Improve and update network-ng.md document
* Update current status.
* Add a plan.
* Add information about the UI layer and interface builders.
@imobachgs imobachgs referenced this pull request Jul 19, 2019
2 of 2 tasks complete

@jreidinger jreidinger merged commit fb813ef into network-ng Jul 19, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Docker Build Task Summary
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@imobachgs imobachgs deleted the network-ng-write-connection-config branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.