From 9a8cd8dbdcdef15cc7a53ef7a92692da76acf5a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ladislav=20Slez=C3=A1k?= Date: Thu, 8 Jan 2015 19:31:38 +0100 Subject: [PATCH] code review fixes - "eol" improvements --- src/OnlineUpdateDialogs.ycp | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/OnlineUpdateDialogs.ycp b/src/OnlineUpdateDialogs.ycp index 188a89d..836a7ad 100644 --- a/src/OnlineUpdateDialogs.ycp +++ b/src/OnlineUpdateDialogs.ycp @@ -373,10 +373,9 @@ some of them might not work as expected."); list eol_products() { integer time_now = time(); - list products = installed_products(); - return (list)filter(map p, products, { - return p["eol"]:nil != nil && tointeger(p["eol"]:"0") < time_now; + return (list)filter(map p, installed_products(), { + return p["eol"]:nil != nil && p["eol"]:-1 < time_now; }); } @@ -419,13 +418,9 @@ Contact us if you need further assistance." list products_to_report = eol_products(); y2milestone("Number of products out of support: %1", size(products_to_report)); - if (size(products_to_report) == 0) - { - return; - } + if (size(products_to_report) == 0) return; list product_names = []; - foreach(map product, products_to_report, { y2milestone("Product out of support: %1", product);