New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add online repos during installation #385

Merged
merged 10 commits into from Nov 15, 2018

Conversation

Projects
None yet
4 participants
@shundhammer
Contributor

shundhammer commented Nov 14, 2018

Trello

https://trello.com/c/VgNO1EBi/442-ludwigs-favorite-feature-leap-151-add-possibility-to-add-online-updates-repo-during-installation

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1112937

Changes Summary

  • Support for adding online repos during installation

  • Added pop-up dialog to ask user first if he would like to add online repos during installation and upgrade (only once)

Details

During installation or upgrade, this now opens a pop-up dialog first:

yast2-001

If memory is low, it also comes with a warning:

yast2-001

(only one of those two is displayed)

If the user clicks on "Yes", the next step is configuring which online repos to use:

yast2-002

When going back and forth in the workflow, the behavior is consistent:

  • The pop-up is only posted once if the user answered with "Yes", so the full-fledged dialog is then shown immediately, no matter how often the user goes back and forth.

  • If the user answered the pop-up with "No", the module is skipped when going backwards, so the first dialog (license / language / keyboard) is shown; when going forward again, the pop-up is shown again so the user still has a chance to get online repos.

In other modes, there may be the old low memory warning dialog. The module now makes sure to show that warning only once; if the new pop-up is shown, it already contains that warning, so the old warning is not shown.

Related PR

yast/skelcd-control-openSUSE#151

Stakeholder Feedback

Demonstrated to and approved by @lnussel.

He extended the first (simpler) pop-up dialog text, and he requested to skip this workflow step entirely if no network is available.

His reasoning was that the network is configured early in the workflow anyway, and having yet another network configuration from this online repos module (which it can do!) would only add confusion rather than be helpful.

@coveralls

This comment has been minimized.

coveralls commented Nov 14, 2018

Coverage Status

Coverage decreased (-0.03%) to 28.451% when pulling 79d796b on shundhammer:huha-online-repos-01 into c84cd6e on yast:master.

@lslezak

LGTM

@shundhammer shundhammer merged commit c46732e into yast:master Nov 15, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@yast-bot

This comment has been minimized.

yast-bot commented Nov 15, 2018

✔️ Public Jenkins job #17 successfully finished
✔️ Created OBS submit request #649271

@yast-bot

This comment has been minimized.

yast-bot commented Nov 15, 2018

✔️ Internal Jenkins job #19 successfully finished
✔️ Created IBS submit request #177664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment