GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related to https://bugzilla.suse.com/show_bug.cgi?id=1098576
Limit the regcode InputField to 512 (bsc#1098576)
well ... a bit useless comment ;-)
Actually, it "explains" why that control was introduced, linking to the associated bug. As far as I have understood until now (reading the code), this is a quite common practice in YaST. Isn't it?
If you want, I could reword it to something like Avoid to send too large request limiting the size of registration code (bsc#1098576) or whatever other reasonable suggestion :)
Avoid to send too large request limiting the size of registration code (bsc#1098576)
I'm fine with the current comment, the most important part is the bug number which is present.
Coverage increased (+0.006%) to 71.519% when pulling c7d2a5f on feature/bsc-1098576 into 8548311 on master.
@lslezak does it make sense to also limit min length when already touching the code?
Update version and changelog
✔️ Public Jenkins job #9 successfully finished
✔️ Public Jenkins job #10 successfully finished