New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the regcode input field #398

Merged
merged 2 commits into from Sep 4, 2018

Conversation

Projects
None yet
5 participants
@dgdavid
Member

dgdavid commented Sep 4, 2018

@dgdavid dgdavid requested a review from lslezak Sep 4, 2018

@@ -65,6 +65,9 @@ def run
Yast::GetInstArgs.enable_next || Yast::Mode.normal
)
# Limit the reg_code InputField to 512 (bsc#1098576)

This comment has been minimized.

@mchf

mchf Sep 4, 2018

Member

well ... a bit useless comment ;-)

@mchf

mchf Sep 4, 2018

Member

well ... a bit useless comment ;-)

This comment has been minimized.

@dgdavid

dgdavid Sep 4, 2018

Member

Actually, it "explains" why that control was introduced, linking to the associated bug. As far as I have understood until now (reading the code), this is a quite common practice in YaST. Isn't it?

If you want, I could reword it to something like Avoid to send too large request limiting the size of registration code (bsc#1098576) or whatever other reasonable suggestion :)

@dgdavid

dgdavid Sep 4, 2018

Member

Actually, it "explains" why that control was introduced, linking to the associated bug. As far as I have understood until now (reading the code), this is a quite common practice in YaST. Isn't it?

If you want, I could reword it to something like Avoid to send too large request limiting the size of registration code (bsc#1098576) or whatever other reasonable suggestion :)

This comment has been minimized.

@lslezak

lslezak Sep 4, 2018

Member

I'm fine with the current comment, the most important part is the bug number which is present.

@lslezak

lslezak Sep 4, 2018

Member

I'm fine with the current comment, the most important part is the bug number which is present.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 4, 2018

Coverage Status

Coverage increased (+0.006%) to 71.519% when pulling c7d2a5f on feature/bsc-1098576 into 8548311 on master.

coveralls commented Sep 4, 2018

Coverage Status

Coverage increased (+0.006%) to 71.519% when pulling c7d2a5f on feature/bsc-1098576 into 8548311 on master.

@mchf

This comment has been minimized.

Show comment
Hide comment
@mchf

mchf Sep 4, 2018

Member

@lslezak does it make sense to also limit min length when already touching the code?

Member

mchf commented Sep 4, 2018

@lslezak does it make sense to also limit min length when already touching the code?

@lslezak

lslezak approved these changes Sep 4, 2018

LGTM

@@ -65,6 +65,9 @@ def run
Yast::GetInstArgs.enable_next || Yast::Mode.normal
)
# Limit the reg_code InputField to 512 (bsc#1098576)

This comment has been minimized.

@lslezak

lslezak Sep 4, 2018

Member

I'm fine with the current comment, the most important part is the bug number which is present.

@lslezak

lslezak Sep 4, 2018

Member

I'm fine with the current comment, the most important part is the bug number which is present.

@dgdavid dgdavid merged commit b5ecb77 into master Sep 4, 2018

4 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 71.519%
Details

@dgdavid dgdavid deleted the feature/bsc-1098576 branch Sep 4, 2018

@lslezak

This comment has been minimized.

Show comment
Hide comment
@lslezak

lslezak Sep 7, 2018

Member

✔️ Public Jenkins job #9 successfully finished

Member

lslezak commented Sep 7, 2018

✔️ Public Jenkins job #9 successfully finished

@dgdavid dgdavid referenced this pull request Sep 10, 2018

Closed

Squad Sprint 62 Post Draft #163

@yast-bot

This comment has been minimized.

Show comment
Hide comment
@yast-bot

yast-bot Sep 11, 2018

✔️ Public Jenkins job #10 successfully finished

yast-bot commented Sep 11, 2018

✔️ Public Jenkins job #10 successfully finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment