Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only record the first 2 numbers of kernel version #50

Merged
merged 1 commit into from Jul 9, 2020

Conversation

bmwiedemann
Copy link
Contributor

Only record the first 2 numbers of kernel version
as it is the most significant for the output.
Maybe kernel is not needed at all.

Helps to make package build results less dependent on kernel version
https://bugzilla.suse.com/show_bug.cgi?id=1173918

See also https://reproducible-builds.org/ for why this matters.

@wfeldt
Copy link
Member

wfeldt commented Jul 9, 2020

please up the version in package/yast2-sound.spec and add a changelog entry to package/yast2-sound.changes

as it is the most significant for the output.
Maybe kernel is not needed at all.

Helps to make package build results less dependent on kernel version
https://bugzilla.suse.com/show_bug.cgi?id=1173918

See also https://reproducible-builds.org/ for why this matters.
Copy link
Member

@wfeldt wfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@wfeldt wfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wfeldt wfeldt merged commit f1a9655 into yast:master Jul 9, 2020
1 check passed
@yast-bot
Copy link

yast-bot commented Jul 9, 2020

✔️ Public Jenkins job #22 successfully finished
✔️ Created OBS submit request #819749

@bmwiedemann bmwiedemann deleted the uname branch July 9, 2020 16:44
@yast-bot
Copy link

✔️ Internal Jenkins job #7 successfully finished
✔️ Created IBS submit request #224095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants