Show the dynamic buttons set in the main table of devices#1024
Show the dynamic buttons set in the main table of devices#1024
Conversation
dgdavid
force-pushed
the
overview_with_dinamyc_buttons
branch
from
1bd990d to
f89ca9d
Compare
dgdavid
force-pushed
the
overview_with_dinamyc_buttons
branch
from
f89ca9d to
11cf5c8
Compare
| def buttons | ||
| buttons = [rescan_devices_button] | ||
| buttons << import_mount_points_button if Yast::Mode.installation | ||
| buttons << HStretch() |
There was a problem hiding this comment.
is there some agreement or decision to change how buttons look like? I see screenshot and not 100% sure it is better as it can have some original intention.
There was a problem hiding this comment.
I was discussing it for a while with @ancorgs locally. I proposed it (to have the discussion locally) in the daily call this morning, to make it faster and avoid uploading a bunch of useless screenshots.
There was a problem hiding this comment.
When we revamped the Partitioner interface in 15.1 we adopted a consistent buttons layout (agreed after many conversations among UX experts and developers) in all screens containing tables of devices except in two:
- The NFS one because it's rendered by yast2-nfs-client
- This one... for no particular reason. We simply did run out of time and energy to discuss it.
Since then, we have been considering the reasons for the old layout (two buttons at the left and another one at the right)... and we have found none. I guess it simply looked nicer to someone back then.
So we decided the time has come to make this screen consistent with all the others (well, except NFS, but that's another story).
And that consistency implies:
- The first line of buttons is "contextual" (depends on the selected item) and aligned to the left
- The second line are global buttons (they affect the whole list) and are aligned to the right
dgdavid
force-pushed
the
overview_with_dinamyc_buttons
branch
from
06190c6 to
fa5a31a
Compare
Necessary to avoid clearing the selected row when the user has not left the system overview page yet.
dgdavid
force-pushed
the
overview_with_dinamyc_buttons
branch
from
fa5a31a to
42475db
Compare
dgdavid
force-pushed
the
overview_with_dinamyc_buttons
branch
from
42475db to
ac0465d
Compare
|
✔️ Public Jenkins job #250 successfully finished |
|
✔️ Internal Jenkins job #73 successfully finished |
5 participants
Problem
The system overview page does not include the
DeviceButtonSetat the bottom of the devices table. And... there is no arguable reason for it :)Solution
To use those dynamic (and useful) buttons also on that page.
Side effects
To make the changes fully consistent with the rest of Partitioner pages, the second buttons row has been realigned to the right. Now, all pages follows the same pattern: contextual actions closest to the table and aligned to the left and general actions below but aligned to the right.
Tests
Screenshots
Click to show/hide screenshots before realigning buttons
ncurses 85x24
ncurses 85x24
Click to show/hide screenshots after realigning buttons
ncurses 85x24
ncurses 85x24