From 008ea264c962381834b61633c93c853cf003373e Mon Sep 17 00:00:00 2001 From: Martin Vidner Date: Wed, 15 May 2019 15:19:06 +0200 Subject: [PATCH 1/4] Untranslated error message in 'Edit Btrfs subvolumes'/'Add subvolume' (bsc#1130822) add missing 'textdomain' call --- src/lib/y2partitioner/dialogs/btrfs_subvolume.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/y2partitioner/dialogs/btrfs_subvolume.rb b/src/lib/y2partitioner/dialogs/btrfs_subvolume.rb index 6c531dfab2..fda33e49a9 100644 --- a/src/lib/y2partitioner/dialogs/btrfs_subvolume.rb +++ b/src/lib/y2partitioner/dialogs/btrfs_subvolume.rb @@ -102,6 +102,7 @@ class SubvolumePath < CWM::InputField # @param form [Dialogs::BtrfsSubvolume::Form] # @param filesystem [Y2Storage::Filesystems::BlkFilesystem] a btrfs filesystem def initialize(form, filesystem: nil) + textdomain "storage" @form = form @filesystem = filesystem end @@ -236,6 +237,7 @@ class SubvolumeNocow < CWM::CheckBox # @param form [Dialogs::BtrfsSubvolume::Form] # @param filesystem [Y2Storage::Filesystems::BlkFilesystem] a btrfs filesystem def initialize(form, filesystem: nil) + textdomain "storage" @form = form @filesystem = filesystem end From 32dfdec06cd966bc05a04c42539e40d8f5f3e68e Mon Sep 17 00:00:00 2001 From: Martin Vidner Date: Mon, 20 May 2019 14:34:30 +0200 Subject: [PATCH 2/4] Detect missing textdomain during testing (bsc#1130822) --- test/spec_helper.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/spec_helper.rb b/test/spec_helper.rb index d8a31d407c..21d5058d3c 100644 --- a/test/spec_helper.rb +++ b/test/spec_helper.rb @@ -26,6 +26,8 @@ # make sure we run the tests in English locale # (some tests check the output which is marked for translation) ENV["LC_ALL"] = "en_US.UTF-8" +# fail fast if a class does not declare textdomain (bsc#1130822) +ENV["Y2STRICTTEXTDOMAIN"] = "1" LIBS_TO_SKIP = ["y2packager/repository"] From bcde2f279a2f8882ae802b3939ed4c85e00dbdc9 Mon Sep 17 00:00:00 2001 From: Martin Vidner Date: Mon, 20 May 2019 14:59:36 +0200 Subject: [PATCH 3/4] Fixed more untranslated messages "Format System Volumes", "/etc/fstab found on /dev/sda1 contains:" --- src/lib/y2partitioner/dialogs/import_mount_points.rb | 1 + src/lib/y2partitioner/widgets/fstab_selector.rb | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/lib/y2partitioner/dialogs/import_mount_points.rb b/src/lib/y2partitioner/dialogs/import_mount_points.rb index 5555ec3ee7..9db10272cd 100644 --- a/src/lib/y2partitioner/dialogs/import_mount_points.rb +++ b/src/lib/y2partitioner/dialogs/import_mount_points.rb @@ -87,6 +87,7 @@ class FormatWidget < CWM::CheckBox # # @param controller [Actions::Controllers::Fstabs] def initialize(controller) + textdomain "storage" @controller = controller end diff --git a/src/lib/y2partitioner/widgets/fstab_selector.rb b/src/lib/y2partitioner/widgets/fstab_selector.rb index d7b95b433b..acba394b41 100644 --- a/src/lib/y2partitioner/widgets/fstab_selector.rb +++ b/src/lib/y2partitioner/widgets/fstab_selector.rb @@ -191,6 +191,7 @@ class FstabContent < CWM::CustomWidget # # @param fstab [Y2Storage::Fstab] def initialize(fstab) + textdomain "storage" @fstab = fstab end @@ -235,6 +236,7 @@ class FstabTable < Widgets::BlkDevicesTable # # @param fstab [Y2Storage::Fstab] def initialize(fstab) + textdomain "storage" @fstab = fstab end From df0679a2916b177a4a40e28367695e54972a364f Mon Sep 17 00:00:00 2001 From: Martin Vidner Date: Wed, 11 Nov 2020 16:02:39 +0100 Subject: [PATCH 4/4] version + changelog --- package/yast2-storage-ng.changes | 8 ++++++++ package/yast2-storage-ng.spec | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/package/yast2-storage-ng.changes b/package/yast2-storage-ng.changes index 7a048a818a..828fcdf693 100644 --- a/package/yast2-storage-ng.changes +++ b/package/yast2-storage-ng.changes @@ -1,3 +1,11 @@ +------------------------------------------------------------------- +Wed Nov 11 14:44:26 UTC 2020 - Martin Vidner + +- Untranslated error message in 'Edit Btrfs subvolumes'/ + 'Add subvolume' (bsc#1130822) +- Detect missing textdomain during unit testing. +- 4.3.20 + ------------------------------------------------------------------- Thu Nov 5 10:26:55 UTC 2020 - Stefan Hundhammer diff --git a/package/yast2-storage-ng.spec b/package/yast2-storage-ng.spec index 6820a90e97..9fdc1acfe3 100644 --- a/package/yast2-storage-ng.spec +++ b/package/yast2-storage-ng.spec @@ -16,7 +16,7 @@ # Name: yast2-storage-ng -Version: 4.3.19 +Version: 4.3.20 Release: 0 Summary: YaST2 - Storage Configuration License: GPL-2.0-only OR GPL-3.0-only