Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial guided proposal: multidisks first #953

Merged
merged 8 commits into from Aug 19, 2019

Conversation

@dgdavid
Copy link
Member

commented Aug 8, 2019

Problem

Currently, the initial guided proposal tries first to install the product into individual disks, adjusting the default settings as much as possible (disabling snapshots, separated home, etc) before attempt to use several disks to fulfill the requirements. This is not useful in certain scenarios in which the product has been designed to be expanded over as many disks as possible, like SUSE Manager.

Solution

Add a new configuration value to the control file and use it to decide how many groups of candidate devices will be generated.

It has been called multidisk_first and it's false by default. When set to true, the initial proposal will be tried using only one group containing all available candidate devices, resulting in a proposal which will use several disks before adjusting the settings.

Testing

  • Added unit tests
  • Also tested manually via dud.

Screenshots

Click to show/hide screenshots

Screenshot_test_2019-08-11_01:09:00

Installing SUSE Manager Server


Screenshot_test_2019-08-11_01:30:22

Initial proposal uses as much devices as possible (1/2).

Screenshot_test_2019-08-11_01:30:30

Initial proposal uses as much devices as possible (2/2).


Screenshot_test_2019-08-11_01:31:07

Using the expert partitioner to see the initial proposal.


Screenshot_test_2019-08-11_01:32:22

Device graph of the initial proposal.

@dgdavid dgdavid force-pushed the suma_try_first_with_all_disks branch from 628f173 to e3667fb Aug 8, 2019

@coveralls

This comment has been minimized.

Copy link

commented Aug 8, 2019

Coverage Status

Coverage increased (+0.0005%) to 97.623% when pulling 27c7074 on suma_try_first_with_all_disks into 75be818 on master.

@dgdavid dgdavid force-pushed the suma_try_first_with_all_disks branch from e3667fb to b53c0c9 Aug 8, 2019

dgdavid added 2 commits Aug 8, 2019
Add unit tests for the multidisk_first approach
For both "allocate volume modes", :auto and :device

@dgdavid dgdavid force-pushed the suma_try_first_with_all_disks branch from f88af7b to fd21db8 Aug 10, 2019

dgdavid added 3 commits Aug 9, 2019
Fix small bug in #candidate_roots
Found while testing the multidisk_first option. The
InitialGuidedProposal#candidate_roots must use #explicit_candidate_devices instead

@dgdavid dgdavid force-pushed the suma_try_first_with_all_disks branch from fd21db8 to 426a4ca Aug 10, 2019

@dgdavid dgdavid marked this pull request as ready for review Aug 11, 2019

@dgdavid dgdavid changed the title Suma try first with all disks Initial guided proposal: multidisks first Aug 11, 2019

@dgdavid dgdavid requested review from joseivanlopez and ancorgs Aug 12, 2019

@dgdavid dgdavid force-pushed the suma_try_first_with_all_disks branch from 8ec401b to 0311db5 Aug 14, 2019

@dgdavid dgdavid force-pushed the suma_try_first_with_all_disks branch from 0311db5 to b82d8fc Aug 14, 2019

doc/old_and_new_proposal.md Outdated Show resolved Hide resolved
src/lib/y2storage/proposal_settings.rb Outdated Show resolved Hide resolved
src/lib/y2storage/proposal_settings.rb Outdated Show resolved Hide resolved
src/lib/y2storage/proposal_settings.rb Show resolved Hide resolved

@dgdavid dgdavid force-pushed the suma_try_first_with_all_disks branch 2 times, most recently from 3348267 to b56ebac Aug 16, 2019

@dgdavid dgdavid force-pushed the suma_try_first_with_all_disks branch from b56ebac to 326eb91 Aug 18, 2019

Update from code review
Co-Authored-By: José Iván López González <jlopez@suse.com>

@dgdavid dgdavid force-pushed the suma_try_first_with_all_disks branch from 326eb91 to 27c7074 Aug 18, 2019

@joseivanlopez
Copy link
Contributor

left a comment

LGTM

@dgdavid dgdavid merged commit a8c8b0d into master Aug 19, 2019

9 checks passed

Debug Task Summary
Details
Package Build Task Summary
Details
Rubocop Task Summary
Details
Unit Tests Task Summary
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0005%) to 97.623%
Details
yardoc Task Summary
Details

@dgdavid dgdavid deleted the suma_try_first_with_all_disks branch Aug 19, 2019

@yast-bot

This comment has been minimized.

Copy link

commented Aug 19, 2019

✔️ Public Jenkins job #195 successfully finished
✔️ Created OBS submit request #724488

@yast-bot

This comment has been minimized.

Copy link

commented Aug 19, 2019

✔️ Internal Jenkins job #20 successfully finished
✔️ Created IBS submit request #199156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.