Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind-mount /run from inst-sys to target system during install (bsc#1136463) #958

Merged
merged 2 commits into from Aug 30, 2019

Conversation

@wfeldt
Copy link
Collaborator

commented Aug 29, 2019

Problem

https://bugzilla.suse.com/show_bug.cgi?id=1136463

Files in /run are needed also in the target system during installation.

That's basically bnc#717321 but again for storage-ng.

Solution

Bind-mount /run into target system.

See also

https://bugzilla.suse.com/show_bug.cgi?id=717321

Same issue in SLE12, fixed in old storage stack.

https://github.com/yast/yast-storage/blob/SLE-12-SP5/src/clients/inst_prepdisk.rb#L143-L166

Testing

Tested manually.

…36463)

That's basically bnc#717321 but for storage-ng.
@coveralls

This comment has been minimized.

Copy link

commented Aug 29, 2019

Coverage Status

Coverage increased (+0.0002%) to 97.626% when pulling 1f5a561 on sw_26 into 9bc6e19 on master.

@kobliha

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Just a note: See https://github.com/yast/yast-packager/blob/d4a21e0ac882b23b68a935367b89e8a1ca6fb273/src/clients/inst_kickoff.rb#L32-L45

We already similarly mount /dev/ at a different place. I even thought we did it for more...

@wfeldt

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 29, 2019

I've seen it.

Still, the canonical place seems to be inst_prepdisk as that's the place used also in the old storage times.

Of course, we unmount /run in umount_finish...

Copy link
Contributor

left a comment

LGTM. I'm just curious about why we left /run out when we ported this from storage to storage-ng initially (done here #108). But since I didn't find any reason or explanation for that in Trello or Bugzilla, I guess there was no good reason and bringing it back is correct.

@wfeldt wfeldt merged commit 9da4ea1 into master Aug 30, 2019
9 checks passed
9 checks passed
Debug Task Summary
Details
Package Build Task Summary
Details
Rubocop Task Summary
Details
Unit Tests Task Summary
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0002%) to 97.626%
Details
yardoc Task Summary
Details
@wfeldt wfeldt deleted the sw_26 branch Aug 30, 2019
@yast-bot

This comment has been minimized.

Copy link

commented Aug 30, 2019

✔️ Public Jenkins job #200 successfully finished
✔️ Created OBS submit request #727182

@yast-bot

This comment has been minimized.

Copy link

commented Aug 30, 2019

✔️ Internal Jenkins job #25 successfully finished
✔️ Created IBS submit request #199918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.