bind-mount /run from inst-sys to target system during install (bsc#1136463)

[wfeldt]

Problem

https://bugzilla.suse.com/show_bug.cgi?id=1136463

Files in /run are needed also in the target system during installation.

That's basically bnc#717321 but again for storage-ng.

Solution

Bind-mount /run into target system.

See also

https://bugzilla.suse.com/show_bug.cgi?id=717321

Same issue in SLE12, fixed in old storage stack.

https://github.com/yast/yast-storage/blob/SLE-12-SP5/src/clients/inst_prepdisk.rb#L143-L166

Testing

Tested manually.

[coveralls]

Coverage increased (+0.0002%) to 97.626% when pulling 1f5a561 on sw_26 into 9bc6e19 on master.

[kobliha]

Just a note: See https://github.com/yast/yast-packager/blob/d4a21e0ac882b23b68a935367b89e8a1ca6fb273/src/clients/inst_kickoff.rb#L32-L45

We already similarly mount /dev/ at a different place. I even thought we did it for more...

[wfeldt]

I've seen it.

Still, the canonical place seems to be inst_prepdisk as that's the place used also in the old storage times.

Of course, we unmount /run in umount_finish...

[ancorgs]

LGTM. I'm just curious about why we left /run out when we ported this from storage to storage-ng initially (done here #108). But since I didn't find any reason or explanation for that in Trello or Bugzilla, I guess there was no good reason and bringing it back is correct.

[yast-bot]

✔️ Public Jenkins job #200 successfully finished
✔️ Created OBS submit request #727182

[yast-bot]

✔️ Internal Jenkins job #25 successfully finished
✔️ Created IBS submit request #199918