Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE-11 SP4: Use stdin, not tmp files for passwords (bsc#986971) #223

Merged
merged 2 commits into from Aug 22, 2016
Merged

SLE-11 SP4: Use stdin, not tmp files for passwords (bsc#986971) #223

merged 2 commits into from Aug 22, 2016

Conversation

shundhammer
Copy link
Contributor

Backport to SLE-11 SP4.

This is very close (but not exactly the same) as the backport to SLE-12 GA. Prior to SLE-12 GA, libstorage was part of the yast2-storage package, thus the different package name here.

Also, in that version there were considerably less constants defined for all kinds of external tools; they were all over the place in the code. This is why the SLE-12 GA patch did not apply cleanly in Volume.cc and Volume.h.

SLE-12 GA patch for comparison:

openSUSE/libstorage#163

Please notice that this pull request is strictly about the patch being equivalent to the ones for SLE-12 GA and SLE-12 SP1. I tried to keep the patch as minimalistic as possible, so please let's avoid style discussions. The patch is tested and proven to work for SLE-12 GA and SP1.

result = fputc( _stdinText[ count++ ], _childStdin );

_stdinText.erase( 0, count );
// y2deb( count << " characters written; left over: \"" << _stdinText << "\"" );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: if you do not need this line then simply remove it, avoid dead code...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, in principle, yes; it's a matter of habit to keep useful debugging code (albeit commented out) in case it's useful in the future again for any debugging.

@lslezak
Copy link
Member

lslezak commented Aug 22, 2016

Adding a small LGTM as I'm not a C++ nor a storage expert. 😉

@shundhammer shundhammer merged commit 15cb22b into yast:Code-11-SP4 Aug 22, 2016
@shundhammer shundhammer deleted the huha-pipe-systemcmd-SLE-11-SP4 branch September 14, 2016 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants