SLE-11 SP4: Use stdin, not tmp files for passwords (bsc#986971) #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Backport to SLE-11 SP4.
This is very close (but not exactly the same) as the backport to SLE-12 GA. Prior to SLE-12 GA, libstorage was part of the yast2-storage package, thus the different package name here.
Also, in that version there were considerably less constants defined for all kinds of external tools; they were all over the place in the code. This is why the SLE-12 GA patch did not apply cleanly in Volume.cc and Volume.h.
SLE-12 GA patch for comparison:
openSUSE/libstorage#163
Please notice that this pull request is strictly about the patch being equivalent to the ones for SLE-12 GA and SLE-12 SP1. I tried to keep the patch as minimalistic as possible, so please let's avoid style discussions. The patch is tested and proven to work for SLE-12 GA and SP1.