New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Home Limit Check #301

Merged
merged 4 commits into from Aug 28, 2018

Conversation

Projects
None yet
2 participants
@shundhammer
Contributor

shundhammer commented Aug 23, 2018

Trello

https://trello.com/c/CRZ147Oh/186-5-sles12-sp4-p3-1085169-build-0230-openqa-test-fails-in-partitioninglvm-fails-to-propose-home-partition-put-proposed-itself

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1085169

Problem

yast-storage-old checked the limit when to propose a separate home partition differently between

  • partition-based proposal
  • LVM-based proposal (both plain and encrypted)

In one case, it took the other partitions that needed to be created into account (swap, /boot, /efi-boot), in the other it didn't. This is inconsistent.

Ideal Solution

Make the proposal great again consistent in all cases. Always take the other partitions into account.

Pragmatic Solution

Take the swap partition into account and just ignore the boot partition(s). This is what this PR does.

While it would be nice to be exact, the code adding a boot partition is all over the place in StorageProposal.rb and its 117 functions in its 6722 lines of code. That old code can only handle one single boot partition; it's either /boot or PreP or an EFI boot partition or whatever; if it's anything else than /boot, it is modified for its true purpose as a final step. This does not make the code any clearer.

Anyway, since a boot partition is only a few MiB anyway, this doesn't change the overall calculation that much; this is about the same order of magnitude than overhead due to LVM management which in the other case would also cause a slight difference. I think we can live with that.

Trying not to overengineer this.

@shundhammer shundhammer changed the title from WIP: Consistent Home Limit Check to Consistent Home Limit Check Aug 27, 2018

@joseivanlopez

LGTM

@shundhammer shundhammer merged commit fd770aa into yast:SLE-12-SP4 Aug 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shundhammer shundhammer deleted the shundhammer:huha-home-limit branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment