New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document, test and improve unssuported scenarios #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
893918e
to
049e518
Compare
In general LGTM, and it was already approved by @kobliha , so, feel free to apply the suggestions and/or merge it |
Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.com>
src/modules/Sudo.rb
Outdated
begin | ||
Report.Error(Message.CannotReadCurrentSettings) if !ReadSudoSettings2() | ||
rescue UnsupportedSudoConfig => e | ||
msg = _("Unsupported configuration found. YaST2 exits now to prevent breaking system.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about YaST will now exit to prevent from breaking the system.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine for me
One little comment and LGTM 👍 |
✔️ Public Jenkins job #12 successfully finished |
✔️ Internal Jenkins job #6 successfully finished |
related trello: https://trello.com/c/Wj8zx82g/1781-8-yast-sudo-new-better-parser
Goal of this PBI is to document what is supported and what not. Add example sudoers file that can be used to testing its ability. Also adding unit test for parsing part. And improve three things:
@include
and@includedir
Screenshots
old error report when write failed:
new one with better error message:
Unsupported multiple tags:
Unsupported digest: