RootPart partially adapted to use storage-ng #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed imports from RootPart.rb and rootpart.rb * Now the unit tests pass and the code to replace actually starts
lslezak
reviewed
Mar 3, 2017
src/modules/RootPart.rb
Outdated
| @@ -1869,36 +1806,32 @@ def IncompleteInstallationDetected(mounted_to) | |||
| ret | |||
| end | |||
|
|
|||
| # Check a root partition and return map with infomations (see | |||
| # Check a root partition and return map with informations (see | |||
There was a problem hiding this comment.
NP: information is singular only in English.
src/modules/RootPart.rb
Outdated
| ) | ||
| end | ||
| end | ||
| if Mode.test |
There was a problem hiding this comment.
NP: Please drop the Mode.test support completely when you are already touching this, the old testsuite has been removed anyway...
lslezak
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://trello.com/c/rf9jCXSW/519-5-storageng-upgrade-rootpart-rb-part-1
Tested manually. With this, the upgrade process can go several steps further.