Fix groups

[jreidinger]

Issue: difference between old and new users in group is not detectable.

Fix: ensure it creates original group even when just syncing from edit user. And also ensure it do deep clone.

[coveralls]

Pull Request Test Coverage Report for Build 1311494142

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 56.193%

---

Totals
Change from base Build 1307493660:	0.0%
Covered Lines:	2849
Relevant Lines:	5070

---

💛 - Coveralls

[ancorgs]

The change makes sense, but at first glance I don't see why this works correctly in the master branch (I tested it manually and seemed to work) without this fix.

[jreidinger]

@ancorgs well, what I expect is that it is enough that group reason is "user_change" https://github.com/yast/yast-users/blob/master/src/modules/Users.pm#L1796
and then write just write new list of users there if there is such modified flag.
On other hand linux writer check different between original and new config and in this case it result that both userlists are same and so do not write modified users list - https://github.com/yast/yast-users/blob/master/src/lib/y2users/linux/users_writer.rb#L334

[ancorgs]

@jreidinger got it. Makes sense, the version in master is "configuration-file-driven". It regenerates /etc/passwd and/or /etc/group as a whole when something changes and I guess there are many ways in which such a rewrite can be triggered.

[ancorgs]

LGTM