From 51276f2e0a057227fd1274a7fb56f48b9f43f645 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ladislav=20Slez=C3=A1k?= Date: Fri, 15 Feb 2019 17:48:10 +0100 Subject: [PATCH 1/4] Fixed evaluating release notes --- .../src/lib/y2packager/release_notes_fetchers/rpm.rb | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/library/packages/src/lib/y2packager/release_notes_fetchers/rpm.rb b/library/packages/src/lib/y2packager/release_notes_fetchers/rpm.rb index 58d44f1cd..36494fa48 100644 --- a/library/packages/src/lib/y2packager/release_notes_fetchers/rpm.rb +++ b/library/packages/src/lib/y2packager/release_notes_fetchers/rpm.rb @@ -174,9 +174,15 @@ def release_notes_file(directory, prefs) langs << prefs.user_lang.split("_", 2).first if prefs.user_lang.include?("_") langs << prefs.fallback_lang - path = Dir.glob( - File.join(directory, "**", "RELEASE-NOTES.{#{langs.join(",")}}.#{prefs.format}") - ).first + path = nil + langs.any? do |lang| + path = Dir.glob( + File.join(directory, "**", "RELEASE-NOTES.#{lang}.#{prefs.format}") + ).first + + !path.nil? + end + return nil if path.nil? [path, path[/RELEASE-NOTES\.(.+)\.#{prefs.format}\z/, 1]] if path end From ce3caf3683347607aa8eadb01bdf9b5ea1a4e4f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ladislav=20Slez=C3=A1k?= Date: Fri, 15 Feb 2019 18:53:40 +0100 Subject: [PATCH 2/4] Mock the debugger presence Do not fail when the debugger is installed --- library/commandline/test/commandline_test.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/library/commandline/test/commandline_test.rb b/library/commandline/test/commandline_test.rb index c764d16f3..66fb3f714 100755 --- a/library/commandline/test/commandline_test.rb +++ b/library/commandline/test/commandline_test.rb @@ -15,6 +15,10 @@ Yast::Mode.SetUI(orig_ui) end + before do + allow(Yast::Debugger).to receive(:installed?).and_return(false) + end + it "invokes initialize, handler and finish" do expect(STDOUT).to receive(:puts).with("Initialize called").ordered expect(STDOUT).to receive(:puts).with("something").ordered From 8e4fce47ae84258aca2da68cf11dcb204bd0c9d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ladislav=20Slez=C3=A1k?= Date: Fri, 15 Feb 2019 22:55:00 +0100 Subject: [PATCH 3/4] Added missing mock in the firewalld test --- library/network/test/firewalld_wrapper_test.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/library/network/test/firewalld_wrapper_test.rb b/library/network/test/firewalld_wrapper_test.rb index 5a2c9028e..7cc6184ac 100755 --- a/library/network/test/firewalld_wrapper_test.rb +++ b/library/network/test/firewalld_wrapper_test.rb @@ -15,6 +15,7 @@ allow(subject).to receive(:firewalld).and_return(firewalld) allow(firewalld).to receive(:zones).and_return(zones) allow(firewalld).to receive(:installed?).and_return(true) + allow(Yast::NetworkInterfaces).to receive(:List).with("").and_return([]) external.interfaces = ["eth0"] external.services = ["dhcp"] end From 9938998b050c09ff6a8dea9191c83ad9d278bc42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ladislav=20Slez=C3=A1k?= Date: Mon, 18 Feb 2019 08:50:04 +0100 Subject: [PATCH 4/4] Version + changes --- package/yast2.changes | 7 +++++++ package/yast2.spec | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/package/yast2.changes b/package/yast2.changes index a1d4c8b44..ef15da652 100644 --- a/package/yast2.changes +++ b/package/yast2.changes @@ -1,3 +1,10 @@ +------------------------------------------------------------------- +Mon Feb 18 07:47:37 UTC 2019 - lslezak@suse.cz + +- Fixed license file ordering issue causing a random test failure + (gh#yast-yast2#895) +- 4.1.55 + ------------------------------------------------------------------- Thu Feb 7 10:01:59 UTC 2019 - knut.anderssen@suse.com diff --git a/package/yast2.spec b/package/yast2.spec index 558be975a..b0516673f 100644 --- a/package/yast2.spec +++ b/package/yast2.spec @@ -17,7 +17,7 @@ Name: yast2 -Version: 4.1.54 +Version: 4.1.55 Release: 0 Summary: YaST2 - Main Package License: GPL-2.0-only