From aa6d6b3d4ac5c124de24a54566aecd141a5e951d Mon Sep 17 00:00:00 2001 From: Stefan Schubert Date: Fri, 12 Jan 2018 14:40:56 +0100 Subject: [PATCH] [Review] Request from 'schubi2' @ 'yast/yast-yast2/review_180112_missing_package' (#668) * return empty hash if package has not been installed --- library/network/src/lib/y2firewall/firewalld.rb | 1 + package/yast2.changes | 7 +++++++ package/yast2.spec | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/library/network/src/lib/y2firewall/firewalld.rb b/library/network/src/lib/y2firewall/firewalld.rb index a278a29e0..c748647ef 100644 --- a/library/network/src/lib/y2firewall/firewalld.rb +++ b/library/network/src/lib/y2firewall/firewalld.rb @@ -102,6 +102,7 @@ def write # # @return [Hash] dump firewalld settings def export + return {} unless installed? { "default_zone" => default_zone, "log_denied_packets" => log_denied_packets, diff --git a/package/yast2.changes b/package/yast2.changes index 63a1dfcec..8c34c8a4d 100644 --- a/package/yast2.changes +++ b/package/yast2.changes @@ -1,3 +1,10 @@ +------------------------------------------------------------------- +Fri Jan 12 14:13:38 CET 2018 - schubi@suse.de + +- Firewalld export: Return empty hash if the package has not + been installed. (fate#323460) +- 4.0.34 + ------------------------------------------------------------------- Wed Jan 10 17:24:18 CET 2018 - schubi@suse.de diff --git a/package/yast2.spec b/package/yast2.spec index c3bb0aae8..777a0f33b 100644 --- a/package/yast2.spec +++ b/package/yast2.spec @@ -16,7 +16,7 @@ # Name: yast2 -Version: 4.0.33 +Version: 4.0.34 Release: 0 Summary: YaST2 - Main Package License: GPL-2.0