From 7e2e276bd10ca70defdb02ccd183c4ecbe36f6b9 Mon Sep 17 00:00:00 2001 From: Masafumi Koba <473530+ybiquitous@users.noreply.github.com> Date: Wed, 27 May 2020 09:06:58 +0900 Subject: [PATCH] feat: bump minimum node version (`engines.node`) (#613) --- package.json | 2 +- test/init.test.js | 13 +++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index a34c04ff..a54c48ee 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ ".remarkignore" ], "engines": { - "node": ">=10" + "node": ">=10.17.0" }, "dependencies": { "@commitlint/cli": "^8.3.5", diff --git a/test/init.test.js b/test/init.test.js index 55bb4d75..8e99a6a9 100644 --- a/test/init.test.js +++ b/test/init.test.js @@ -1,17 +1,20 @@ const path = require("path"); const os = require("os"); +const fs = require("fs"); const fse = require("fs-extra"); const test = require("tape"); const pkg = require("../package.json"); const init = require("../lib/init"); const exec = require("./helpers/exec"); -const readFile = (file) => fse.readFile(file, "utf8"); -const readJSON = (file) => fse.readJSON(file, "utf8"); +/* eslint-disable node/no-unsupported-features/node-builtins */ +const readFile = (file) => fs.promises.readFile(file, "utf8"); +const readJSON = (file) => fs.promises.readFile(file, "utf8").then(JSON.parse); +/* eslint-enable node/no-unsupported-features/node-builtins */ const sandbox = async (fn, t) => { const workDir = path.join(os.tmpdir(), `${pkg.name}${Date.now()}`); - await fse.mkdirs(workDir); + await fs.promises.mkdir(workDir); // eslint-disable-line node/no-unsupported-features/node-builtins const logMsgs = []; const logger = (msg) => logMsgs.push(msg); @@ -22,7 +25,7 @@ const sandbox = async (fn, t) => { const fixture = async (name) => { const src = fixturePath(name); const dest = path.join(workDir, "package.json"); - await fse.copy(src, dest); + await fs.promises.copyFile(src, dest); // eslint-disable-line node/no-unsupported-features/node-builtins return dest; }; @@ -37,6 +40,8 @@ const sandbox = async (fn, t) => { initArgs: { cwd: workDir, logger }, }); } finally { + // TODO: Node 12+ + // await fs.promises.rmdir(workDir, { recursive: true }); await fse.remove(workDir); } };