Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the Makefile #13

Closed
driesmp opened this issue Oct 7, 2018 · 4 comments
Closed

Get rid of the Makefile #13

driesmp opened this issue Oct 7, 2018 · 4 comments

Comments

@driesmp
Copy link

driesmp commented Oct 7, 2018

I'm trying to port your program to FreeBSD altough the Makefile is casuing problems.
As the install targets are not default; calling pip commands etc.
Can you make it so that you only rely on setup.py and setup.cfg?

Two nice examples are:
https://github.com/certbot/certbot
https://github.com/sivel/speedtest-cli/

For the python porting toolchain you can take a look at this:
https://github.com/freebsd/freebsd-ports/blob/master/Mk/Uses/python.mk

Thanks

@driesmp
Copy link
Author

driesmp commented Oct 7, 2018

You can find my in progress work here: https://github.com/Duffyx/pyznap
I error out with the following:
image

@driesmp driesmp changed the title Get rid op the Makefile Get rid of the Makefile Oct 7, 2018
@yboetz
Copy link
Owner

yboetz commented Oct 7, 2018

You don't need the Makefile. It's just for convenience, but if you use the command pip install pyznap the Makefile is not used. It's just as a shorthand for make release to automatically upload to pypi.

i don't really know FreeBSD, so I don't really know what the problem is here.

@driesmp
Copy link
Author

driesmp commented Oct 9, 2018

Somehow the FreeBSD make framework picks up the Makefile of you and fails because of it.
I"ll check with FreeBSD mail list on this issue.

@driesmp driesmp closed this as completed Oct 9, 2018
@driesmp
Copy link
Author

driesmp commented Oct 10, 2018

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232161
Fixed it. Was a stupid typo in my Makefile LOL .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants