From 360dfd7923f2c66d41ef208c0527cad43ee74488 Mon Sep 17 00:00:00 2001 From: Shaunak Kashyap Date: Fri, 2 Jun 2017 13:08:07 -0700 Subject: [PATCH] Revert "When on an embedded page, bypass Getting Started gate check (#12040)" This reverts commit 05293f1c8d765179a0d2973df16617e653323f83. --- .../public/lib/__tests__/add_setup_work.js | 10 ---------- .../getting_started/public/lib/add_setup_work.js | 5 ----- 2 files changed, 15 deletions(-) diff --git a/src/core_plugins/getting_started/public/lib/__tests__/add_setup_work.js b/src/core_plugins/getting_started/public/lib/__tests__/add_setup_work.js index 9ceabb222d12c0..bf526140db1121 100644 --- a/src/core_plugins/getting_started/public/lib/__tests__/add_setup_work.js +++ b/src/core_plugins/getting_started/public/lib/__tests__/add_setup_work.js @@ -31,16 +31,6 @@ describe('Getting Started page', () => { set($route, 'current.$$route', {}); }); - describe('if the user is on an embedded page', () => { - beforeEach(() => { - set($route, 'current.params.embed', true); - }); - - it('should not show the UI chrome', () => { - expect(uiChrome.getVisible()).to.be(false); - }); - }); - describe('if index patterns exist', () => { beforeEach(() => { config = { diff --git a/src/core_plugins/getting_started/public/lib/add_setup_work.js b/src/core_plugins/getting_started/public/lib/add_setup_work.js index d1be97d86015c9..3c9bf39cbcfded 100644 --- a/src/core_plugins/getting_started/public/lib/add_setup_work.js +++ b/src/core_plugins/getting_started/public/lib/add_setup_work.js @@ -75,11 +75,6 @@ function showGettingStartedPage(kbnUrl, isOnGettingStartedPage) { export function gettingStartedGateCheck(getIds, kbnUrl, config, $route) { const currentRoute = get($route, 'current.$$route'); const isOnGettingStartedPage = get(currentRoute, 'originalPath') === GETTING_STARTED_ROUTE; - const isOnEmbeddedPage = Boolean(get($route, 'current.params.embed', false)); - - if (isOnEmbeddedPage) { - return Promise.resolve(); - } return getIds() .then(indexPatterns => {