Repository navigation
feat: add rows limit to query settings - #1291
Conversation
| name="limitRows" | ||
| control={control} | ||
| render={({field}) => ( | ||
| <React.Fragment> |
| {QUERY_SETTINGS_FIELD_SETTINGS.limitRows.title} | ||
| </label> | ||
| <div className={b('control-wrapper')}> | ||
| <Controller |
There was a problem hiding this comment.
let's add validation in Controller?
| querySettings.tracingLevel && enableTracingLevel | ||
| ? TracingLevelNumber[querySettings.tracingLevel] | ||
| : undefined, | ||
| limit_rows: querySettings.limitRows || undefined, |
There was a problem hiding this comment.
will it be possible to run query without this setting at all?
There was a problem hiding this comment.
now it is running without this setting
or I didnt get your idea
There was a problem hiding this comment.
Just wanted to double-check that limit_rows may be undefined and nothing breaks!
ValeraS
left a comment
ValeraS
left a comment
There was a problem hiding this comment.
It seems you need to update some tests.
|
@ValeraS Actually we cant use z.coerce as it changes the original values |
Why are timeout and rows limit not numbers? |
I suppose it's because TextInput works with strings |
How types of query options depend on view(TextInput)? |
no need in typecasts in view props |
3 participants
Closes #1253
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 79.01 MB | Main: 78.99 MB
Diff: +0.02 MB (0.02%)
ℹ️ CI Information