Repository navigation
feat: hide some columns and storage nodes for users-viewers - #1967
Merged
Merged
Conversation
artemmufazalov
commented
Feb 19, 2025
Comment on lines
+5
to
+7
| export function useIsUserAllowedToMakeChanges() { | ||
| return useTypedSelector(selectIsUserAllowedToMakeChanges); | ||
| } |
Member
Author
There was a problem hiding this comment.
Created a custom hook to import one function instead of two, no changes in this part
artemmufazalov
marked this pull request as ready for review
February 19, 2025 10:33
artemmufazalov
requested review from
Raubzeug and
astandrik
and removed request for
astandrik
February 19, 2025 10:33
artemmufazalov
force-pushed
the
1408-limit-columns
branch
from
February 19, 2025 10:34
8649a5c to
b0045f7
Compare
Raubzeug
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1408
How UI will look like for users-viewers: https://nda.ya.ru/t/BAWCJ3407C7NKx
Changes for users with
isMonitoringAllowed: false:CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 80.46 MB | Main: 80.46 MB
Diff: +1.97 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information