Skip to content

feat: redesign query - #1974

Merged
astandrik merged 54 commits into
mainfrom
astandrik.redesign-query-1949
Feb 28, 2025
Merged

astandrik merged 54 commits into
mainfrom
astandrik.redesign-query-1949

Conversation

@astandrik

@astandrik astandrik commented Feb 21, 2025 •

Copy link
Copy Markdown
Contributor

Closes #1949
Stand

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
264 263 0 0 1
Test Changes Summary ✨5 ⏭️1 🗑️4

✨ New Tests (5)

  1. Error is displayed for invalid query for run (tenant/queryEditor/queryEditor.test.ts)
  2. Error is displayed for invalid query for explain (tenant/queryEditor/queryEditor.test.ts)
  3. Query streaming finishes in reasonable time (tenant/queryEditor/queryEditor.test.ts)
  4. Streaming query shows some results and banner when stop button is clicked (tenant/queryEditor/queryEditor.test.ts)
  5. Truncated results for multiple tabs (tenant/queryEditor/queryEditor.test.ts)

⏭️ Skipped Tests (1)

  1. Streaming query shows some results and banner when stop button is clicked (tenant/queryEditor/queryEditor.test.ts)

🗑️ Deleted Tests (4)

  1. Error is displayed for invalid query (tenant/queryEditor/queryEditor.test.ts)
  2. Stop button and elapsed time label disappear after query is stopped (tenant/queryEditor/queryEditor.test.ts)
  3. Indicator icon appears after closing banner (tenant/queryEditor/querySettings.test.ts)
  4. Indicator not appears for running query (tenant/queryEditor/querySettings.test.ts)

Bundle Size: 🔺

Current: 80.79 MB | Main: 80.78 MB
Diff: +0.01 MB (0.01%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik
astandrik requested a review from Copilot February 21, 2025 13:58
@astandrik astandrik changed the title Astandrik.redesign query 1949 feat: redesign query Feb 21, 2025
@astandrik
astandrik marked this pull request as ready for review February 21, 2025 13:59
@astandrik
astandrik requested review from Copilot and removed request for Copilot February 21, 2025 14:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 25 changed files in this pull request and generated 2 comments.

Files not reviewed (15)
  • src/components/ElapsedTime/ElapsedTime.scss: Language not supported
  • src/components/QueryExecutionStatus/QueryExecutionStatus.scss: Language not supported
  • src/containers/Tenant/Query/CancelQueryButton/CancelQueryButton.scss: Language not supported
  • src/containers/Tenant/Query/QueryDuration/QueryDuration.scss: Language not supported
  • src/containers/Tenant/Query/QueryEditorControls/EditorButton.scss: Language not supported
  • src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.scss: Language not supported
  • src/containers/Tenant/Query/QueryResult/QueryResultViewer.scss: Language not supported
  • src/containers/Tenant/Query/QueryResult/components/QueryResultError/QueryResultError.scss: Language not supported
  • src/containers/Tenant/Query/QueryResult/components/ResultSetsViewer/ResultSetsViewer.scss: Language not supported
  • src/components/ElapsedTime/ElapsedTime.tsx: Evaluated as low risk
  • src/containers/Tenant/Query/CancelQueryButton/CancelQueryButton.tsx: Evaluated as low risk
  • src/containers/Tenant/Query/QueryDuration/QueryDuration.tsx: Evaluated as low risk
  • src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx: Evaluated as low risk
  • src/components/QueryExecutionStatus/QueryExecutionStatus.tsx: Evaluated as low risk
  • src/containers/Tenant/Query/QueryResult/QueryResultViewer.tsx: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx:63

  • Add a null check for cancelQueryResponse before calling the reset method to avoid potential runtime errors.
cancelQueryResponse.reset();

src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx:104

  • [nitpick] Ensure that the renderStopButton function is not called redundantly to improve code efficiency.
const renderStopButton = () => (

@ydb-platform ydb-platform deleted a comment from Copilot AI Feb 21, 2025
@ydb-platform ydb-platform deleted a comment from Copilot AI Feb 21, 2025
@astandrik
astandrik requested a review from Raubzeug February 24, 2025 14:37

@Raubzeug Raubzeug left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If switch to Diagnostics and than back to Query, query duration starts from zero. And Run button starts animate as if query starts again.

@astandrik

Copy link
Copy Markdown
Contributor Author

@Raubzeug made fixes - now it should work as expected

@astandrik
astandrik requested a review from Raubzeug February 27, 2025 14:27
Comment thread playwright.config.ts
: {
command: 'npm run dev',
env: {
REACT_APP_DISABLE_CHECKS: 'true',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled rtk-immutability checks for tests (in prod its disabled by default)
drastically improves stream tables performance

Raubzeug
Raubzeug previously approved these changes Feb 28, 2025
@astandrik
astandrik added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 9ac8cfc Feb 28, 2025
@astandrik
astandrik deleted the astandrik.redesign-query-1949 branch February 28, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign queries page

3 participants