Repository navigation
feat: redesign query - #1974
Merged
Merged
feat: redesign query#1974
Conversation
astandrik
marked this pull request as ready for review
February 21, 2025 13:59
Contributor
There was a problem hiding this comment.
Copilot reviewed 10 out of 25 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- src/components/ElapsedTime/ElapsedTime.scss: Language not supported
- src/components/QueryExecutionStatus/QueryExecutionStatus.scss: Language not supported
- src/containers/Tenant/Query/CancelQueryButton/CancelQueryButton.scss: Language not supported
- src/containers/Tenant/Query/QueryDuration/QueryDuration.scss: Language not supported
- src/containers/Tenant/Query/QueryEditorControls/EditorButton.scss: Language not supported
- src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/QueryResultViewer.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/QueryResultError/QueryResultError.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/ResultSetsViewer/ResultSetsViewer.scss: Language not supported
- src/components/ElapsedTime/ElapsedTime.tsx: Evaluated as low risk
- src/containers/Tenant/Query/CancelQueryButton/CancelQueryButton.tsx: Evaluated as low risk
- src/containers/Tenant/Query/QueryDuration/QueryDuration.tsx: Evaluated as low risk
- src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx: Evaluated as low risk
- src/components/QueryExecutionStatus/QueryExecutionStatus.tsx: Evaluated as low risk
- src/containers/Tenant/Query/QueryResult/QueryResultViewer.tsx: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx:63
- Add a null check for cancelQueryResponse before calling the reset method to avoid potential runtime errors.
cancelQueryResponse.reset();
src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx:104
- [nitpick] Ensure that the renderStopButton function is not called redundantly to improve code efficiency.
const renderStopButton = () => (
Raubzeug
requested changes
Feb 27, 2025
Contributor
Author
|
@Raubzeug made fixes - now it should work as expected |
astandrik
commented
Feb 27, 2025
| : { | ||
| command: 'npm run dev', | ||
| env: { | ||
| REACT_APP_DISABLE_CHECKS: 'true', |
Contributor
Author
There was a problem hiding this comment.
disabled rtk-immutability checks for tests (in prod its disabled by default)
drastically improves stream tables performance
Raubzeug
previously approved these changes
Feb 28, 2025
This reverts commit f45de0c.
Raubzeug
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1949
Stand
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ✨5 ⏭️1 🗑️4
✨ New Tests (5)
⏭️ Skipped Tests (1)
🗑️ Deleted Tests (4)
Bundle Size: 🔺
Current: 80.79 MB | Main: 80.78 MB
Diff: +0.01 MB (0.01%)
ℹ️ CI Information