From 0d172686e79c98a374b7262df7f6b01949553dd4 Mon Sep 17 00:00:00 2001 From: Anton Standrik Date: Tue, 15 Apr 2025 17:57:25 +0300 Subject: [PATCH] fix: display query settings banner for non-default api call or txmode --- src/utils/hooks/useChangedQuerySettings.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/utils/hooks/useChangedQuerySettings.ts b/src/utils/hooks/useChangedQuerySettings.ts index b6e05d2e21..6f8011556a 100644 --- a/src/utils/hooks/useChangedQuerySettings.ts +++ b/src/utils/hooks/useChangedQuerySettings.ts @@ -14,7 +14,7 @@ export const useChangedQuerySettings = () => { const [lastQuerySettings] = useLastQueryExecutionSettings(); const [currentQuerySettings] = useQueryExecutionSettings(); - const changedLastExucutionSettings = lastQuerySettings + const changedLastExecutionSettings = lastQuerySettings ? getChangedQueryExecutionSettings(lastQuerySettings, DEFAULT_QUERY_SETTINGS) : []; @@ -22,7 +22,9 @@ export const useChangedQuerySettings = () => { ? getChangedQueryExecutionSettings(currentQuerySettings, DEFAULT_QUERY_SETTINGS) : []; - const hasChangedLastExucutionSettings = changedLastExucutionSettings.length > 0; + const hasChangedImportantSettings = + changedLastExecutionSettings.includes('transactionMode') || + changedLastExecutionSettings.includes('queryMode'); const changedLastExecutionSettingsDescriptions = lastQuerySettings ? getChangedQueryExecutionSettingsDescription({ @@ -42,8 +44,7 @@ export const useChangedQuerySettings = () => { bannerLastClosedTimestamp && Date.now() - bannerLastClosedTimestamp < WEEK_IN_SECONDS * 1000; - const isBannerShown = hasChangedLastExucutionSettings && !isClosedRecently; - const isIndicatorShown = hasChangedLastExucutionSettings && isClosedRecently; + const isBannerShown = hasChangedImportantSettings && !isClosedRecently; const closeBanner = () => setBannerLastClosedTimestamp(Date.now()); @@ -51,14 +52,13 @@ export const useChangedQuerySettings = () => { return { isBannerShown, - isIndicatorShown, closeBanner, resetBanner, changedCurrentSettings, changedCurrentSettingsDescriptions, - changedLastExucutionSettings, + changedLastExecutionSettings, changedLastExecutionSettingsDescriptions, }; };