Skip to content

Conversation

@DaryaVorontsova
Copy link
Contributor

@DaryaVorontsova DaryaVorontsova commented Nov 12, 2025

Stand: https://nda.ya.ru/t/UlMK3WpF7Msfdk

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 374 0 2 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 66.09 MB | Main: 66.08 MB
Diff: +0.01 MB (0.02%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 12, 2025

Skipped: This PR does not contain any of your configured keywords: (greptile-review)

@DaryaVorontsova
Copy link
Contributor Author

ydb-platform/ydb#25583

@DaryaVorontsova
Copy link
Contributor Author

ydb-platform/ydb#25585

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for this file, it is transferred from my previous PR - #3060

queryText = stripAllLeadingIndent(queryText);
queryText = normalizeParameter(queryText);

const bodyQueryText = queryText ? indentBlock(queryText) : ' {current query text}';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if no query text is presented, lets do stub as snippet ${2:<streaming_query_text>}

function stripAllLeadingIndent(str: string) {
return str
.split('\n')
.map((line) => line.replace(/^[ \t]+/, ''))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trim?

@DaryaVorontsova DaryaVorontsova added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 5e503fc Nov 13, 2025
7 checks passed
@DaryaVorontsova DaryaVorontsova deleted the feat/streaming-query-actions branch November 13, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants