feat: add creating directory through context menu in navigation tree - #958
Merged
Merged
Conversation
Contributor
|
Press "Enter" does't confirm creating a directory. |
Raubzeug
requested changes
Jun 28, 2024
| </div> | ||
| <div>{`${parent}/`}</div> | ||
| </div> | ||
| <TextInput |
Contributor
There was a problem hiding this comment.
Could you please clarify with Xeno if we need any validation here?
Raubzeug
requested changes
Jul 1, 2024
| const handleCreateDirectorySubmit = (child: string) => { | ||
| createDirectory({database: parent, path: `${parent}/${child}`}); | ||
|
|
||
| onActivePathUpdate(`${parent}/${child}`); |
Contributor
There was a problem hiding this comment.
It seems we should do it after directory is created (wait for createDirectory answer).
|
|
||
| onActivePathUpdate(`${parent}/${child}`); | ||
|
|
||
| setCreateDirectoryOpen(false); |
Contributor
There was a problem hiding this comment.
same here. I would set some loading state to dialog Apply buttons and close dialog on request success. If request fails we may show an error inside the dialog's body.
| @import '../../../../styles/mixins.scss'; | ||
|
|
||
| .ydb-schema-create-directory-dialog { | ||
| &__modal { |
Contributor
There was a problem hiding this comment.
It seems this class is redundant.
Contributor
|
One more - we should disable "Apply" button, if directory name is empty. |
ValeraS
requested changes
Jul 1, 2024
ValeraS
left a comment
ValeraS
left a comment
Contributor
There was a problem hiding this comment.
Please try not using UseEffect, all current uses are redundant.
| React.useEffect(() => { | ||
| if (createDirectoryResult.isError) { | ||
| const errorMessage = | ||
| (createDirectoryResult.error as {data: string})?.data || ' Unknown error'; |
Contributor
There was a problem hiding this comment.
Does the error contain a message?
Contributor
Author
There was a problem hiding this comment.
The error contains only such fields
{
"data": "{ status: SCHEME_ERROR, issues: { <main>: Error: Check failed: path: '/local/.sys_health/±', error: symbol '?' is not allowed in the path part '±' } }",
"status": 400,
"statusText": "Bad Request",
"headers": {
"content-length": "140",
"content-type": "text/plain"
},
"config": {
"transitional": {
"silentJSONParsing": true,
"forcedJSONParsing": true,
"clarifyTimeoutError": false
},
"adapter": [
"xhr",
"http"
],
"transformRequest": [
null
],
"transformResponse": [
null
],
"timeout": 60000,
"xsrfCookieName": "",
"xsrfHeaderName": "X-XSRF-TOKEN",
"maxContentLength": -1,
"maxBodyLength": -1,
"env": {},
"headers": {
"Accept": "application/json, text/plain, */*",
"Content-Type": "application/json"
},
"withCredentials": false,
"signal": {},
"method": "post",
"url": "http://localhost:8765/scheme/directory",
"data": "{}",
"params": {
"database": "/local/.sys_health",
"path": "/local/.sys_health/±"
},
"axios-retry": {
"retries": 3,
"shouldResetTimeout": false,
"validateResponse": null,
"retryCount": 0,
"lastRequestTime": 1719906437941
}
},
"request": {}
}
ValeraS
requested changes
Jul 2, 2024
| <div className={b('description')}>{i18n('schema.tree.dialog.description')}</div> | ||
| <div>{`${parentPath}/`}</div> | ||
| </div> | ||
| <TextInput |
Contributor
There was a problem hiding this comment.
Let's wrap it to form and call validation and mutation on submit.
ValeraS
reviewed
Jul 2, 2024
ValeraS
requested changes
Jul 3, 2024
| error={hasValidationError} | ||
| /> | ||
| <div className={b('error-wrapper')}> | ||
| {hasValidationError && <ResponseError error={validationError} />} |
Contributor
There was a problem hiding this comment.
why is this not in the TextInput's errorMessage?
Contributor
There was a problem hiding this comment.
To prevent dialog's height jumping.
| textButtonApply={i18n('schema.tree.dialog.buttonApply')} | ||
| textButtonCancel={i18n('schema.tree.dialog.buttonCancel')} | ||
| onClickButtonCancel={handleClose} | ||
| propsButtonApply={{disabled: hasValidationError, type: 'submit'}} |
Contributor
There was a problem hiding this comment.
Suggested change
| propsButtonApply={{disabled: hasValidationError, type: 'submit'}} | |
| propsButtonApply={{type: 'submit'}} |
Contributor
There was a problem hiding this comment.
You suggest not to disable Apply button at all? But why?
Contributor
There was a problem hiding this comment.
Why do you want to disable it? There is a validation before submission.
Contributor
There was a problem hiding this comment.
If it's validation error, we 100% know, that "Apply" won't work.
Or maybe I just like to forbid :)
| } | ||
|
|
||
| export function CreateDirectoryDialog({open, onClose, parentPath, onSuccess}: SchemaTreeProps) { | ||
| const [error, setError] = React.useState<unknown>(''); |
Contributor
There was a problem hiding this comment.
Why is this needed? response contains error.
| autoFocus | ||
| hasClear | ||
| disabled={response.isLoading} | ||
| error={hasValidationError} |
ValeraS
requested changes
Jul 4, 2024
|
|
||
| export function CreateDirectoryDialog({open, onClose, parentPath, onSuccess}: SchemaTreeProps) { | ||
| const [error, setError] = React.useState<unknown>(''); | ||
| const [showResponseError, setShowResponseError] = React.useState(false); |
Contributor
There was a problem hiding this comment.
response has a reset method
| <Dialog.Body> | ||
| <div className={b('label')}> | ||
| <div className={b('description')}> | ||
| <label htmlFor={relativePathInputName} className={b('label')}> |
Contributor
There was a problem hiding this comment.
for attribute should be connected to an id of input not a name.
Raubzeug
force-pushed
the
feat/createDirectory-915
branch
from
July 4, 2024 11:45
90c6b6b to
064ac63
Compare
ValeraS
approved these changes
Jul 4, 2024
Raubzeug
approved these changes
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #915