Repository navigation
feat(AutoRefresh): use auto refresh control on other pages - #976
Merged
Merged
Conversation
ValeraS
force-pushed
the
feat/auto-refresh-control
branch
2 times, most recently
from
July 3, 2024 13:42
c5b99d8 to
caa5a3e
Compare
artemmufazalov
suggested changes
Jul 4, 2024
| <Icon data={ArrowRotateLeft} /> | ||
| {pDiskPageKeyset('restart-pdisk-button')} | ||
| </ButtonWithConfirmDialog> | ||
| <AutoRefreshControl /> |
Member
There was a problem hiding this comment.
It's located too close to restart button. As for me, it creates association, that it somehow correlates with PDIsk restart, not data refecth
In my view, this control should not be on the same level as restart button.
The same comment applicable to VDisk and it's evict button.
ValeraS
force-pushed
the
feat/auto-refresh-control
branch
from
July 4, 2024 12:13
caa5a3e to
982b3b2
Compare
artemmufazalov
approved these changes
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#914