Skip to content

24-3: Add ListNodes cache in DynamicNameserver (#12694) - #12747

Merged
pixcc merged 1 commit into
ydb-platform:stable-24-3from
pixcc:24-3/list-nodes-cache
Dec 19, 2024
Merged

24-3: Add ListNodes cache in DynamicNameserver (#12694)#12747
pixcc merged 1 commit into
ydb-platform:stable-24-3from
pixcc:24-3/list-nodes-cache

Conversation

@pixcc

@pixcc pixcc commented Dec 18, 2024

Copy link
Copy Markdown
Member

Changelog entry

Add caching for ListNodes request in DynamicNameserver

Changelog category

  • Performance improvement

Additional information

Prior to this change, the entire node list was copied for every ListNodes request. This change adds caching of the node list, which is now distributed by pointer. The node list is re-cached when changes are made.

@pixcc
pixcc requested a review from a team as a code owner December 18, 2024 19:56
@pixcc pixcc self-assigned this Dec 18, 2024
@github-actions

github-actions Bot commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

2024-12-18 19:59:32 UTC Pre-commit check for 28d46aa has started.
2024-12-18 20:02:40 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-18 20:44:15 UTC Build successful.
2024-12-18 20:44:31 UTC Tests are running...
🔴 2024-12-18 22:54:54 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14348 14223 0 35 47 43

🟢 2024-12-18 22:55:41 UTC ydbd size 5.6 GiB changed* by +88.7 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: ee4ad94 merge: 28d46aa diff diff %
ydbd size 6 002 448 352 Bytes 6 002 539 152 Bytes +88.7 KiB +0.002%
ydbd stripped size 1 504 173 504 Bytes 1 504 193 536 Bytes +19.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

2024-12-18 20:00:20 UTC Pre-commit check for 28d46aa has started.
2024-12-18 20:03:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-18 21:05:24 UTC Build successful.
2024-12-18 21:05:39 UTC Tests are running...
🔴 2024-12-18 23:17:36 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75533 62047 0 15 13432 39

🟡 2024-12-18 23:18:34 UTC ydbd size 8.3 GiB changed* by +139.6 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: ee4ad94 merge: 28d46aa diff diff %
ydbd size 8 873 359 848 Bytes 8 873 502 752 Bytes +139.6 KiB +0.002%
ydbd stripped size 484 345 064 Bytes 484 350 248 Bytes +5.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc
pixcc enabled auto-merge (squash) December 18, 2024 22:43
@pixcc
pixcc merged commit 11eb58f into ydb-platform:stable-24-3 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants