Skip to content

Fixed errors with transactions in the PQ tablet - #12905

Merged
Alek5andr-Kotov merged 5 commits into
ydb-platform:mainfrom
Alek5andr-Kotov:LOGBROKER-9409
Dec 24, 2024
Merged

Fixed errors with transactions in the PQ tablet#12905
Alek5andr-Kotov merged 5 commits into
ydb-platform:mainfrom
Alek5andr-Kotov:LOGBROKER-9409

Conversation

@Alek5andr-Kotov

@Alek5andr-Kotov Alek5andr-Kotov commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

Changelog entry

Fixed the errors:

  1. The program did not take into account that it can receive a TEvReadSet more times than the number of senders in TEvProposeTransaction. Deleted the check from `Y_ABORT_UNLESS'.
  2. Replaced the Y_ABORT_UNLESS checks with the ForceFalse flag. Instead of an abnormal termination, the program returns ABORTED.

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov changed the title LOGBROKER 9409 WIP: LOGBROKER-9409 Dec 24, 2024
@github-actions

github-actions Bot commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

2024-12-24 08:30:33 UTC Pre-commit check linux-x86_64-release-asan for ea25ddd has started.
2024-12-24 08:30:44 UTC Artifacts will be uploaded here
2024-12-24 08:33:49 UTC ya make is running...
🔴 2024-12-24 08:39:00 UTC Build failed, see the logs. Also see fail summary

@github-actions

github-actions Bot commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

2024-12-24 08:31:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for ea25ddd has started.
2024-12-24 08:31:12 UTC Artifacts will be uploaded here
2024-12-24 08:34:03 UTC ya make is running...
🔴 2024-12-24 08:38:03 UTC Build failed, see the logs. Also see fail summary

@github-actions github-actions Bot added bugfix and removed bugfix labels Dec 24, 2024
@Alek5andr-Kotov Alek5andr-Kotov changed the title WIP: LOGBROKER-9409 Fixed errors with transactions in the PQ tablet Dec 24, 2024
@github-actions github-actions Bot added bugfix and removed bugfix labels Dec 24, 2024
@github-actions

github-actions Bot commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

2024-12-24 09:02:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for e31601a has started.
2024-12-24 09:02:26 UTC Artifacts will be uploaded here
2024-12-24 09:05:17 UTC ya make is running...
🟡 2024-12-24 09:58:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20932 19399 0 4 1415 114

2024-12-24 10:00:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-24 10:12:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
168 (only retried tests) 56 0 0 0 112

🟢 2024-12-24 10:12:39 UTC Build successful.
🟢 2024-12-24 10:12:57 UTC ydbd size 2.1 GiB changed* by +4.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 18ed18e merge: e31601a diff diff %
ydbd size 2 235 030 744 Bytes 2 235 035 416 Bytes +4.6 KiB +0.000%
ydbd stripped size 477 983 088 Bytes 477 984 432 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

2024-12-24 09:04:13 UTC Pre-commit check linux-x86_64-release-asan for e31601a has started.
2024-12-24 09:04:24 UTC Artifacts will be uploaded here
2024-12-24 09:07:15 UTC ya make is running...
🟡 2024-12-24 10:22:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13749 13665 0 25 9 50

🟢 2024-12-24 10:23:11 UTC Build successful.
🟢 2024-12-24 10:23:33 UTC ydbd size 3.6 GiB changed* by +15.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7cd35f3 merge: e31601a diff diff %
ydbd size 3 865 652 520 Bytes 3 865 668 096 Bytes +15.2 KiB +0.000%
ydbd stripped size 1 350 679 408 Bytes 1 350 683 312 Bytes +3.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov
Alek5andr-Kotov marked this pull request as ready for review December 24, 2024 09:53
@Alek5andr-Kotov
Alek5andr-Kotov requested a review from a team as a code owner December 24, 2024 09:53
nshestakov
nshestakov previously approved these changes Dec 24, 2024
@github-actions

github-actions Bot commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

2024-12-24 11:18:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7fd402e has started.
2024-12-24 11:18:34 UTC Artifacts will be uploaded here
2024-12-24 11:21:31 UTC ya make is running...
🟡 2024-12-24 12:19:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20932 19398 0 3 1415 116

2024-12-24 12:22:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-24 12:33:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
166 (only retried tests) 55 0 0 0 111

🟢 2024-12-24 12:33:39 UTC Build successful.
🟢 2024-12-24 12:34:00 UTC ydbd size 2.1 GiB changed* by +6.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7cd35f3 merge: 7fd402e diff diff %
ydbd size 2 235 028 664 Bytes 2 235 035 416 Bytes +6.6 KiB +0.000%
ydbd stripped size 477 983 088 Bytes 477 984 432 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

2024-12-24 11:19:59 UTC Pre-commit check linux-x86_64-release-asan for 7fd402e has started.
2024-12-24 11:20:10 UTC Artifacts will be uploaded here
2024-12-24 11:23:03 UTC ya make is running...
🟡 2024-12-24 12:33:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13749 13678 0 17 7 47

🟢 2024-12-24 12:34:50 UTC Build successful.
🟢 2024-12-24 12:35:11 UTC ydbd size 3.6 GiB changed* by +15.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7cd35f3 merge: 7fd402e diff diff %
ydbd size 3 865 652 520 Bytes 3 865 668 096 Bytes +15.2 KiB +0.000%
ydbd stripped size 1 350 679 408 Bytes 1 350 683 312 Bytes +3.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants