Skip to content

24-3-15-hotfix: Fix uncommitted changes leak and clean them up on startup - #13501

Merged
snaury merged 1 commit into
ydb-platform:stable-24-3-15-hotfixfrom
snaury:bugfix-13387-uncommitted-tx-leak-24-3-15-hotfix
Jan 17, 2025
Merged

snaury merged 1 commit into
ydb-platform:stable-24-3-15-hotfixfrom
snaury:bugfix-13387-uncommitted-tx-leak-24-3-15-hotfix

Conversation

@snaury

@snaury snaury commented Jan 17, 2025

Copy link
Copy Markdown
Member

Changelog entry

Fix uncommitted changes leak and clean them up on startup.

Changelog category

  • Bugfix

Additional information

It was discovered that uncommitted changes are slowly leaking in some workloads, which turned out to be due to writes combined with a broken read-only lock. This patch fixes the issue and adds automatic cleanup on shard startup.

Fixes #13387.

@snaury snaury self-assigned this Jan 17, 2025
@snaury
snaury marked this pull request as ready for review January 17, 2025 14:11
@snaury
snaury requested a review from a team as a code owner January 17, 2025 14:12
@github-actions

github-actions Bot commented Jan 17, 2025 •

Copy link
Copy Markdown
Contributor

⚪ 2025-01-17 14:15:34 UTC Pre-commit check for c1d96b1 has started.
⚪ 2025-01-17 14:18:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-17 15:02:27 UTC Build successful.
⚪ 2025-01-17 15:02:52 UTC Tests are running...
🔴 2025-01-17 16:32:32 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14730 13375 0 15 1300 40

🟡 2025-01-17 16:33:41 UTC ydbd size 8.3 GiB changed* by +478.3 KiB, which is >= 100.0 KiB vs stable-24-3-15-hotfix: Warning

ydbd size dash stable-24-3-15-hotfix: 2034d05 merge: c1d96b1 diff diff %
ydbd size 8 873 807 472 Bytes 8 874 297 232 Bytes +478.3 KiB +0.006%
ydbd stripped size 484 291 656 Bytes 484 296 392 Bytes +4.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Jan 17, 2025 •

Copy link
Copy Markdown
Contributor

⚪ 2025-01-17 14:18:29 UTC Pre-commit check for c1d96b1 has started.
⚪ 2025-01-17 14:21:30 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-17 14:43:26 UTC Build successful.
⚪ 2025-01-17 14:43:55 UTC Tests are running...
🔴 2025-01-17 16:51:54 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10402 10305 0 27 27 43

🟡 2025-01-17 16:52:33 UTC ydbd size 5.6 GiB changed* by +201.6 KiB, which is >= 100.0 KiB vs stable-24-3-15-hotfix: Warning

ydbd size dash stable-24-3-15-hotfix: 2034d05 merge: c1d96b1 diff diff %
ydbd size 6 002 399 592 Bytes 6 002 606 072 Bytes +201.6 KiB +0.003%
ydbd stripped size 1 504 207 424 Bytes 1 504 229 408 Bytes +21.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury
snaury enabled auto-merge (squash) January 17, 2025 14:33
@snaury
snaury merged commit 6af9f62 into ydb-platform:stable-24-3-15-hotfix Jan 17, 2025
@snaury
snaury deleted the bugfix-13387-uncommitted-tx-leak-24-3-15-hotfix branch January 17, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants