Skip to content

24-4: Fix RemoveSubscribedLock crash after DropTable - #15074

Merged
snaury merged 2 commits into
ydb-platform:stable-24-4from
snaury:bugfix-15065-drop-table-read-lock-race-24-4
Feb 27, 2025
Merged

24-4: Fix RemoveSubscribedLock crash after DropTable#15074
snaury merged 2 commits into
ydb-platform:stable-24-4from
snaury:bugfix-15065-drop-table-read-lock-race-24-4

Conversation

@snaury

@snaury snaury commented Feb 26, 2025

Copy link
Copy Markdown
Member

Changelog entry

Fixed a rare crash in datashard when a dropped table shard is restarted with uncommitted persistent changes. Fixes #15065.

Changelog category

  • Bugfix

Description for reviewers

This problem was fixed in main (now 25-1) in #13339, which was triggered by in-memory state migration at the time. As it turns out this problem may be triggered in a more severe case that doesn't involve in-memory state migration and needs to be fixed.

@snaury snaury self-assigned this Feb 26, 2025
@github-actions

github-actions Bot commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

2025-02-26 13:57:06 UTC Pre-commit check for 7d64a18 has started.
2025-02-26 13:59:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-26 14:39:24 UTC Build successful.
2025-02-26 14:39:50 UTC Tests are running...
🔴 2025-02-26 16:10:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14790 13432 0 19 1300 39

🟢 2025-02-26 16:11:20 UTC ydbd size 8.3 GiB changed* by +3.7 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: bd3c9d7 merge: 7d64a18 diff diff %
ydbd size 8 896 418 032 Bytes 8 896 421 840 Bytes +3.7 KiB +0.000%
ydbd stripped size 484 973 160 Bytes 484 973 736 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

2025-02-26 13:57:41 UTC Pre-commit check for 7d64a18 has started.
2025-02-26 14:00:22 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-26 14:24:16 UTC Build successful.
2025-02-26 14:24:54 UTC Tests are running...
🔴 2025-02-26 16:40:18 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10357 10251 0 35 31 40

🟢 2025-02-26 16:41:17 UTC ydbd size 5.6 GiB changed* by -160 Bytes, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: bd3c9d7 merge: 7d64a18 diff diff %
ydbd size 6 026 457 120 Bytes 6 026 456 960 Bytes -160 Bytes -0.000%
ydbd stripped size 1 508 253 056 Bytes 1 508 252 928 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury
snaury marked this pull request as ready for review February 27, 2025 08:02
@snaury
snaury requested a review from a team as a code owner February 27, 2025 08:02
@snaury
snaury merged commit 010638a into ydb-platform:stable-24-4 Feb 27, 2025
@snaury
snaury deleted the bugfix-15065-drop-table-read-lock-race-24-4 branch February 27, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants