Skip to content

reduce interconnect outgoing stream buffer size to 32KB - #15264

Merged
alexd65536 merged 1 commit into
ydb-platform:mainfrom
alexd65536:reduce_ic_output_buffer_size
Mar 3, 2025
Merged

reduce interconnect outgoing stream buffer size to 32KB#15264
alexd65536 merged 1 commit into
ydb-platform:mainfrom
alexd65536:reduce_ic_output_buffer_size

Conversation

@alexd65536

@alexd65536 alexd65536 commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Changelog category

  • Not for changelog (changelog entry is not required)

@github-actions

github-actions Bot commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

🟢 2025-03-03 13:46:11 UTC The validation of the Pull Request description is successful.

@github-actions

github-actions Bot commented Mar 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-03 13:46:25 UTC Pre-commit check linux-x86_64-release-asan for 00d13ea has started.
⚪ 2025-03-03 13:46:41 UTC Artifacts will be uploaded here
⚪ 2025-03-03 13:49:39 UTC ya make is running...
🟡 2025-03-03 14:59:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13766 13592 0 115 24 35

⚪ 2025-03-03 15:01:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 15:24:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
241 (only retried tests) 204 0 4 2 31

⚪ 2025-03-03 15:25:06 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-03 15:39:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 37 0 0 2 30

🟢 2025-03-03 15:40:01 UTC Build successful.
🟢 2025-03-03 15:40:32 UTC ydbd size 3.7 GiB changed* by -192 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 94077e5 merge: 00d13ea diff diff %
ydbd size 3 988 496 864 Bytes 3 988 496 672 Bytes -192 Bytes -0.000%
ydbd stripped size 1 388 507 336 Bytes 1 388 507 272 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Mar 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚪ 2025-03-03 13:48:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 00d13ea has started.
⚪ 2025-03-03 13:48:52 UTC Artifacts will be uploaded here
⚪ 2025-03-03 13:51:43 UTC ya make is running...
🟡 2025-03-03 14:49:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28240 25632 0 2 2466 140

⚪ 2025-03-03 14:52:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-03 15:02:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 87 0 0 0 125

🟢 2025-03-03 15:02:17 UTC Build successful.
🟢 2025-03-03 15:02:35 UTC ydbd size 2.1 GiB changed* by -104 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 94077e5 merge: 00d13ea diff diff %
ydbd size 2 288 461 528 Bytes 2 288 461 424 Bytes -104 Bytes -0.000%
ydbd stripped size 479 649 408 Bytes 479 649 408 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

the-ancient-1
the-ancient-1 approved these changes Mar 3, 2025
View reviewed changes

@the-ancient-1 the-ancient-1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexd65536
alexd65536 merged commit d35b323 into ydb-platform:main Mar 3, 2025
@alexd65536
alexd65536 deleted the reduce_ic_output_buffer_size branch March 3, 2025 17:20
@naspirato naspirato mentioned this pull request Mar 4, 2025
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@alexd65536 @blinkov
reduce interconnect outgoing stream buffer size to 32KB (#15264)
949af55
alexd65536 added a commit that referenced this pull request Apr 8, 2025
@alexd65536
25-1: reduce interconnect outgoing stream buffer size to 32KB (#15264) (
f288dcc 
#16838)
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@the-ancient-1 the-ancient-1 the-ancient-1 approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexd65536 @the-ancient-1