Skip to content

Stable-24-4-4-hotfix: Copy table should not check feature flags for columns types - #17312

Merged
azevaykin merged 2 commits into
ydb-platform:stable-24-4-4-hotfixfrom
azevaykin:stable-24-4-4-hotfix-CopyTable
Apr 17, 2025
Merged

azevaykin merged 2 commits into
ydb-platform:stable-24-4-4-hotfixfrom
azevaykin:stable-24-4-4-hotfix-CopyTable

Conversation

@azevaykin

Copy link
Copy Markdown
Contributor

Changelog entry

Copy table should not check feature flags for columns types. If the types in original table are created then they should be allowed in destination table.

Changelog category

  • Bugfix

Description for reviewers

#17289
#17290

@azevaykin
azevaykin requested a review from a team as a code owner April 17, 2025 06:39
@azevaykin azevaykin linked an issue Apr 17, 2025 that may be closed by this pull request
@github-actions

github-actions Bot commented Apr 17, 2025 •

Copy link
Copy Markdown
Contributor

⚪ 2025-04-17 06:42:57 UTC Pre-commit check for 20b7a3a has started.
⚪ 2025-04-17 06:45:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-04-17 07:28:59 UTC Build successful.
⚪ 2025-04-17 07:29:13 UTC Tests are running...
🔴 2025-04-17 08:58:48 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14821 13455 0 19 1302 45

🟢 2025-04-17 09:00:05 UTC ydbd size 8.3 GiB changed* by +792 Bytes, which is < 100.0 KiB vs stable-24-4-4-hotfix: OK

ydbd size dash stable-24-4-4-hotfix: ae3f393 merge: 20b7a3a diff diff %
ydbd size 8 898 788 656 Bytes 8 898 789 448 Bytes +792 Bytes +0.000%
ydbd stripped size 485 025 128 Bytes 485 025 128 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

github-actions Bot commented Apr 17, 2025 •

Copy link
Copy Markdown
Contributor

⚪ 2025-04-17 06:43:15 UTC Pre-commit check for 20b7a3a has started.
⚪ 2025-04-17 06:46:00 UTC Build linux-x86_64-release-asan is running...
🟢 2025-04-17 07:13:08 UTC Build successful.
⚪ 2025-04-17 07:13:28 UTC Tests are running...
🔴 2025-04-17 09:23:59 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10385 10280 0 34 28 43

🟢 2025-04-17 09:24:54 UTC ydbd size 5.6 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs stable-24-4-4-hotfix: OK

ydbd size dash stable-24-4-4-hotfix: ae3f393 merge: 20b7a3a diff diff %
ydbd size 6 027 985 336 Bytes 6 027 986 456 Bytes +1.1 KiB +0.000%
ydbd stripped size 1 508 488 384 Bytes 1 508 488 128 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin changed the title Stable 24 4 4 hotfix copy table Stable-24-4-4-hotfix: Copy table should not check feature flags for columns types Apr 17, 2025
@azevaykin
azevaykin merged commit 8673a64 into ydb-platform:stable-24-4-4-hotfix Apr 17, 2025
@azevaykin
azevaykin deleted the stable-24-4-4-hotfix-CopyTable branch April 17, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy table fails backward compability

2 participants