Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make coordination session ping period dependent on session timeout KI… #1837

Conversation

snaury
Copy link
Member

@snaury snaury commented Feb 12, 2024

…KIMR-20993 (#1575)

Changelog entry

Coordination session ping period is now dependent on session timeout.

Changelog category

  • Improvement

Additional information

Previously server pinged client session every 5 seconds, which translated to worst case dead client detection of 10 seconds. Some clients needed a faster leader change however, so ping period now depends on the session timeout.

Copy link

github-actions bot commented Feb 12, 2024

2024-02-12 13:46:23 UTC Pre-commit check for e94bd98 has started.
2024-02-12 13:46:25 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-12 13:48:09 UTC Build successful.
2024-02-12 13:48:18 UTC Tests are running...
🔴 2024-02-12 14:59:17 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60346 50920 0 1 9348 77

Copy link

github-actions bot commented Feb 12, 2024

2024-02-12 13:52:11 UTC Pre-commit check for e94bd98 has started.
2024-02-12 13:52:13 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-12 13:53:58 UTC Build successful.
2024-02-12 13:54:07 UTC Tests are running...
🔴 2024-02-12 15:27:28 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16033 15909 0 12 62 50

@snaury snaury marked this pull request as ready for review February 12, 2024 16:32
@snaury snaury requested a review from a team as a code owner February 12, 2024 16:32
@snaury snaury merged commit e95a49c into ydb-platform:stable-24-1 Feb 13, 2024
2 of 4 checks passed
@snaury snaury deleted the KIKIMR-20993-kesus-ping-by-session-timeout-24-1 branch February 13, 2024 11:45
@mvgorbunov mvgorbunov mentioned this pull request Feb 22, 2024
@shnikd shnikd mentioned this pull request Feb 27, 2024
@mregrock mregrock mentioned this pull request May 15, 2024
This was referenced Jun 7, 2024
@CyberROFL CyberROFL mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants