Skip to content

Fix REPLACE INTO handling in incremental backup #24427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2025
Merged

Fix REPLACE INTO handling in incremental backup #24427

merged 3 commits into from
Sep 9, 2025

Conversation

@Enjection
Copy link
Member

@Enjection Enjection commented Sep 8, 2025 •
edited by CyberROFL
Loading

  • fix replace into

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions
Copy link

github-actions bot commented Sep 8, 2025 •
edited
Loading

🟢 2025-09-09 10:08:52 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Sep 8, 2025 •
edited
Loading

⚪ 2025-09-08 13:35:03 UTC Pre-commit check linux-x86_64-release-asan for a788168 has started.
⚪ 2025-09-08 13:35:18 UTC Artifacts will be uploaded here
⚪ 2025-09-08 13:39:07 UTC ya make is running...
🟡 2025-09-08 15:46:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17396 16916 0 132 321 27

🟢 2025-09-08 15:47:44 UTC Build successful.
🟡 2025-09-08 15:48:08 UTC ydbd size 4.0 GiB changed* by +130.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b6aad08 merge: a788168 diff diff %
ydbd size 4 295 729 936 Bytes 4 295 863 376 Bytes +130.3 KiB +0.003%
ydbd stripped size 1 489 076 856 Bytes 1 489 124 248 Bytes +46.3 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 8, 2025 •
edited
Loading

⚪ 2025-09-08 13:35:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for a788168 has started.
⚪ 2025-09-08 13:35:23 UTC Artifacts will be uploaded here
⚪ 2025-09-08 13:39:18 UTC ya make is running...
🟡 2025-09-08 15:12:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40158 37399 0 6 2721 32

⚪ 2025-09-08 15:15:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-09-08 15:30:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
552 (only retried tests) 528 0 1 0 23

⚪ 2025-09-08 15:30:41 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-09-08 15:43:55 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
254 (only retried tests) 231 0 1 0 22

🟢 2025-09-08 15:44:04 UTC Build successful.
🟢 2025-09-08 15:44:23 UTC ydbd size 2.3 GiB changed* by +79.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b6aad08 merge: a788168 diff diff %
ydbd size 2 444 223 976 Bytes 2 444 305 296 Bytes +79.4 KiB +0.003%
ydbd stripped size 511 661 704 Bytes 511 675 144 Bytes +13.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Enjection Enjection force-pushed the bugfix/support-op-6-in-incr-backup branch from ac1f505 to 89d8f9e Compare September 8, 2025 21:12
@github-actions
Copy link

github-actions bot commented Sep 8, 2025 •
edited
Loading

⚪ 2025-09-08 21:14:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 580179f has started.
⚪ 2025-09-08 21:14:30 UTC Artifacts will be uploaded here
⚪ 2025-09-08 21:17:50 UTC ya make is running...
🟡 2025-09-08 22:27:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30902 29501 0 1 1371 29

⚪ 2025-09-08 22:30:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-08 22:40:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
457 (only retried tests) 438 0 0 0 19

🟢 2025-09-08 22:40:17 UTC Build successful.
🟢 2025-09-08 22:40:33 UTC ydbd size 2.3 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ea692f1 merge: 580179f diff diff %
ydbd size 2 444 363 984 Bytes 2 444 365 936 Bytes +1.9 KiB +0.000%
ydbd stripped size 511 688 008 Bytes 511 688 456 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 8, 2025 •
edited
Loading

⚪ 2025-09-08 21:15:22 UTC Pre-commit check linux-x86_64-release-asan for 580179f has started.
⚪ 2025-09-08 21:15:44 UTC Artifacts will be uploaded here
⚪ 2025-09-08 21:19:14 UTC ya make is running...
🟡 2025-09-08 23:25:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15256 14544 0 358 319 35

🟢 2025-09-08 23:26:51 UTC Build successful.
🟢 2025-09-08 23:27:16 UTC ydbd size 4.0 GiB changed* by +5.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ea692f1 merge: 580179f diff diff %
ydbd size 4 295 972 624 Bytes 4 295 978 048 Bytes +5.3 KiB +0.000%
ydbd stripped size 1 489 143 928 Bytes 1 489 145 656 Bytes +1.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Enjection Enjection marked this pull request as ready for review September 8, 2025 21:48
@Enjection Enjection requested a review from a team as a code owner September 8, 2025 21:48
@Enjection Enjection requested a review from CyberROFL September 9, 2025 08:26
CyberROFL
CyberROFL reviewed Sep 9, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Sep 9, 2025 •
edited
Loading

⚪ 2025-09-09 09:38:18 UTC Pre-commit check linux-x86_64-release-asan for 53f2a76 has started.
⚪ 2025-09-09 09:38:31 UTC Artifacts will be uploaded here
⚪ 2025-09-09 09:42:01 UTC ya make is running...
⚫ 2025-09-09 11:11:35 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 9, 2025 •
edited
Loading

⚪ 2025-09-09 09:58:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 53f2a76 has started.
⚪ 2025-09-09 10:00:43 UTC Artifacts will be uploaded here
⚪ 2025-09-09 10:04:48 UTC ya make is running...
⚫ 2025-09-09 11:11:42 UTC Check cancelled

CyberROFL
CyberROFL reviewed Sep 9, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Sep 9, 2025 •
edited
Loading

⚪ 2025-09-09 11:14:50 UTC Pre-commit check linux-x86_64-release-asan for d22e075 has started.
⚪ 2025-09-09 11:15:06 UTC Artifacts will be uploaded here
⚪ 2025-09-09 11:18:29 UTC ya make is running...
🟡 2025-09-09 13:37:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15268 14812 0 126 309 21

🟢 2025-09-09 13:39:02 UTC Build successful.
🟡 2025-09-09 13:39:25 UTC ydbd size 4.0 GiB changed* by +375.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 181055e merge: d22e075 diff diff %
ydbd size 4 296 049 768 Bytes 4 296 434 184 Bytes +375.4 KiB +0.009%
ydbd stripped size 1 489 214 584 Bytes 1 489 318 168 Bytes +101.2 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 9, 2025 •
edited
Loading

⚪ 2025-09-09 11:23:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for d22e075 has started.
⚪ 2025-09-09 11:24:20 UTC Artifacts will be uploaded here
⚪ 2025-09-09 11:28:14 UTC ya make is running...
🟡 2025-09-09 13:27:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30920 29507 0 6 1372 35

⚪ 2025-09-09 13:30:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-09 13:55:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
363 (only retried tests) 332 0 0 8 23

🟢 2025-09-09 13:55:27 UTC Build successful.
🟢 2025-09-09 13:55:45 UTC ydbd size 2.3 GiB changed* by +55.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: dc7aa6f merge: d22e075 diff diff %
ydbd size 2 444 467 792 Bytes 2 444 524 488 Bytes +55.4 KiB +0.002%
ydbd stripped size 511 719 528 Bytes 511 733 384 Bytes +13.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Enjection Enjection enabled auto-merge (squash) September 9, 2025 13:36
@Enjection Enjection merged commit 8d0894e into ydb-platform:main Sep 9, 2025
13 checks passed
Enjection added a commit to Enjection/ydb that referenced this pull request Sep 9, 2025
@Enjection
Fix REPLACE INTO handling in incremental backup (ydb-platform#24427)
f58dadf
@Enjection Enjection mentioned this pull request Sep 9, 2025
Merged
denxc pushed a commit to denxc/ydb that referenced this pull request Sep 11, 2025
@Enjection @denxc
Fix REPLACE INTO handling in incremental backup (ydb-platform#24427)
82d87db
@Enjection Enjection linked an issue Oct 15, 2025 that may be closed by this pull request
ydbd crashes on BACKUP INCREMENTAL after REPLACE INTO #24388
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

+1 more reviewer

@kungasc kungasc kungasc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ydbd crashes on BACKUP INCREMENTAL after REPLACE INTO

3 participants

@Enjection @CyberROFL @kungasc