Fixed Column Shard write stats #24736
Conversation
|
🟢 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where write statistics were not being properly recorded for Column Store operations in NoTx mode by adding shard ID tracking and statistics collection.
- Adds shard ID parameter to
AddTableAccessStatsToTxStatsfunction - Ensures write statistics are collected for both NoTx and transaction modes in Column Store
- Updates test expectations to account for differences between ROW and COLUMN store statistics
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb/core/tx/columnshard/blobs_action/transaction/tx_blobs_written.cpp | Adds shard ID parameter to statistics calls for both NoTx and transaction write modes |
| ydb/core/tx/columnshard/blobs_action/common/statistics.h | Updates function signature to include shard ID parameter |
| ydb/core/tx/columnshard/blobs_action/common/statistics.cpp | Implements shard statistics collection with the new shard ID parameter |
| ydb/core/kqp/ut/query/kqp_stats_ut.cpp | Updates test assertions to handle different byte counts and partition counts between ROW and COLUMN stores |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
4 participants
Changelog entry
Write stats for Column Store even in NoTx mode. Column shards were not reporting table access statistics when queries were executed in immediate transaction mode (all DDL and queries without BEGIN ... COMMIT).
#22446
Changelog category
Description for reviewers
Test also changed to reflect differences between ROW and COLUMN stores