Skip to content

[ICRDMA] Support for RDMA memory region in pdisk, NBYDB-1578 #27580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2025
Merged

[ICRDMA] Support for RDMA memory region in pdisk, NBYDB-1578 #27580

merged 4 commits into from
Oct 27, 2025

Conversation

@dcherednik
Copy link
Member

@dcherednik dcherednik commented Oct 24, 2025

Changelog entry

Common RDMA aware RCBUF allocation infrastructure and pdisk support.

Changelog category

  • Experimental feature

Description for reviewers

...

robdrynkin
robdrynkin previously approved these changes Oct 24, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 15:13:51 UTC Pre-commit check linux-x86_64-release-asan for 1df12a8 has started.
⚪ 2025-10-24 15:14:07 UTC Artifacts will be uploaded here
⚪ 2025-10-24 15:17:28 UTC ya make is running...
⚫ 2025-10-24 15:23:31 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 15:13:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1df12a8 has started.
⚪ 2025-10-24 15:14:13 UTC Artifacts will be uploaded here
⚪ 2025-10-24 15:18:22 UTC ya make is running...
⚫ 2025-10-24 15:23:30 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

🟢 2025-10-27 11:41:37 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 15:24:50 UTC Pre-commit check linux-x86_64-release-asan for 1a81f49 has started.
⚪ 2025-10-24 15:25:04 UTC Artifacts will be uploaded here
⚪ 2025-10-24 15:28:26 UTC ya make is running...
⚫ 2025-10-24 15:29:42 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 15:27:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1a81f49 has started.
⚪ 2025-10-24 15:27:52 UTC Artifacts will be uploaded here
⚫ 2025-10-24 15:29:41 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 15:31:06 UTC Pre-commit check linux-x86_64-release-asan for 6079077 has started.
⚪ 2025-10-24 15:31:21 UTC Artifacts will be uploaded here
⚪ 2025-10-24 15:34:44 UTC ya make is running...
🟡 2025-10-24 18:28:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18395 17918 0 229 230 18

🟢 2025-10-24 18:28:43 UTC Build successful.
🟡 2025-10-24 18:29:10 UTC ydbd size 3.8 GiB changed* by +474.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7090690 merge: 6079077 diff diff %
ydbd size 4 055 718 920 Bytes 4 056 205 240 Bytes +474.9 KiB +0.012%
ydbd stripped size 1 506 031 392 Bytes 1 506 212 384 Bytes +176.8 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 15:32:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6079077 has started.
⚪ 2025-10-24 15:32:57 UTC Artifacts will be uploaded here
⚪ 2025-10-24 15:37:08 UTC ya make is running...
🟡 2025-10-24 18:00:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
42063 39258 0 7 2768 30

⚪ 2025-10-24 18:00:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-24 18:23:25 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1049 (only retried tests) 1031 0 0 0 18

🟢 2025-10-24 18:23:28 UTC Build successful.
🟡 2025-10-24 18:23:44 UTC ydbd size 2.3 GiB changed* by +255.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7090690 merge: 6079077 diff diff %
ydbd size 2 437 327 344 Bytes 2 437 588 840 Bytes +255.4 KiB +0.011%
ydbd stripped size 518 128 456 Bytes 518 165 736 Bytes +36.4 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Enjection
Enjection requested changes Oct 27, 2025
View reviewed changes
Copy link
Member

@Enjection Enjection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cover move-semantics with tests and probably IsPrivate as well.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025 •
edited
Loading

⚪ 2025-10-27 11:14:21 UTC Pre-commit check linux-x86_64-release-asan for 546460f has started.
⚪ 2025-10-27 11:14:47 UTC Artifacts will be uploaded here
⚪ 2025-10-27 11:16:14 UTC ya make is running...
🟡 2025-10-27 14:15:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18396 17871 0 222 280 23

🟢 2025-10-27 14:15:28 UTC Build successful.
🟡 2025-10-27 14:15:52 UTC ydbd size 3.8 GiB changed* by +466.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: db27fa0 merge: 546460f diff diff %
ydbd size 4 055 022 024 Bytes 4 055 500 032 Bytes +466.8 KiB +0.012%
ydbd stripped size 1 505 755 840 Bytes 1 505 928 576 Bytes +168.7 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 27, 2025 •
edited
Loading

⚪ 2025-10-27 11:17:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 546460f has started.
⚪ 2025-10-27 11:17:39 UTC Artifacts will be uploaded here
⚪ 2025-10-27 11:19:03 UTC ya make is running...
🟡 2025-10-27 13:38:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
42067 39261 0 9 2767 30

⚪ 2025-10-27 13:39:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-27 14:05:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
737 (only retried tests) 714 0 2 0 21

⚪ 2025-10-27 14:05:56 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-27 14:27:35 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
468 (only retried tests) 449 0 0 0 19

🟢 2025-10-27 14:27:48 UTC Build successful.
🟡 2025-10-27 14:28:07 UTC ydbd size 2.3 GiB changed* by +255.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: db27fa0 merge: 546460f diff diff %
ydbd size 2 436 880 096 Bytes 2 437 141 472 Bytes +255.2 KiB +0.011%
ydbd stripped size 518 034 952 Bytes 518 072 072 Bytes +36.2 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Enjection Enjection self-requested a review October 27, 2025 11:17
@dcherednik dcherednik changed the title [ICRDMA] Support for RDMA memory region in pdisk [ICRDMA] Support for RDMA memory region in pdisk, NBYDB-1578 Oct 27, 2025
@dcherednik dcherednik enabled auto-merge (squash) October 27, 2025 11:42
@dcherednik dcherednik merged commit 87fe3fd into ydb-platform:main Oct 27, 2025
15 checks passed
@serbel324 serbel324 mentioned this pull request Oct 30, 2025
Merged
dcherednik added a commit to dcherednik/ydb that referenced this pull request Nov 17, 2025
@dcherednik
[ICRDMA] Support for RDMA memory region in pdisk, NBYDB-1578 (ydb-pla…
ac66494 
…tform#27580)

Common RDMA aware RCBUF allocation infrastructure and pdisk support.
dcherednik added a commit that referenced this pull request Nov 19, 2025
@dcherednik
[ICRDMA] Support for RDMA memory region in pdisk, NBYDB-1578 (#27580)
e29d085 
Common RDMA aware RCBUF allocation infrastructure and pdisk support.
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
@dcherednik @qyryq
[ICRDMA] Support for RDMA memory region in pdisk, NBYDB-1578 (ydb-pla…
43d9e24 
…tform#27580)

Common RDMA aware RCBUF allocation infrastructure and pdisk support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Enjection Enjection Enjection approved these changes

@robdrynkin robdrynkin robdrynkin approved these changes

Assignees

No one assigned

Labels

experimental-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcherednik @Enjection @robdrynkin