Skip to content

Conversation

@GrigoriyPA
Copy link
Collaborator

Changelog entry

Improved session actor logs on query fail (added issues and status)

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@GrigoriyPA GrigoriyPA requested a review from Hor911 November 3, 2025 09:27
@GrigoriyPA GrigoriyPA requested a review from a team as a code owner November 3, 2025 09:27
Copilot AI review requested due to automatic review settings November 3, 2025 09:27
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🟢 2025-11-03 09:30:56 UTC The validation of the Pull Request description is successful.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances logging in error handling paths by adding more contextual information to warning log messages. The changes improve debugging capabilities by including issue details and status codes in error logs.

  • Added issue messages to compile error logging
  • Added status codes and optional issue messages to query error logging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

2025-11-03 09:31:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for b8be53e has started.
2025-11-03 09:32:05 UTC Artifacts will be uploaded here
2025-11-03 09:33:36 UTC ya make is running...
🟡 2025-11-03 11:04:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39125 36305 0 3 2792 25

2025-11-03 11:04:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-03 11:18:07 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
53 (only retried tests) 38 0 0 0 15

🟢 2025-11-03 11:18:10 UTC Build successful.
🟢 2025-11-03 11:18:26 UTC ydbd size 2.3 GiB changed* by +9.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1787dd7 merge: b8be53e diff diff %
ydbd size 2 429 281 976 Bytes 2 429 292 024 Bytes +9.8 KiB +0.000%
ydbd stripped size 516 134 920 Bytes 516 137 160 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

2025-11-03 09:31:57 UTC Pre-commit check linux-x86_64-release-asan for b8be53e has started.
2025-11-03 09:32:14 UTC Artifacts will be uploaded here
2025-11-03 09:33:43 UTC ya make is running...
🟡 2025-11-03 11:39:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15532 14872 0 392 242 26

🟢 2025-11-03 11:39:44 UTC Build successful.
🟢 2025-11-03 11:40:08 UTC ydbd size 3.8 GiB changed* by +7.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1787dd7 merge: b8be53e diff diff %
ydbd size 4 068 669 832 Bytes 4 068 677 200 Bytes +7.2 KiB +0.000%
ydbd stripped size 1 510 374 440 Bytes 1 510 376 680 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 4c5fd99 into ydb-platform:main Nov 5, 2025
20 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-4855-add-fail-issues-into-session-actor-logs branch November 5, 2025 11:35
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Nov 6, 2025
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants