Skip to content

Conversation

@yumkam
Copy link
Collaborator

@yumkam yumkam commented Nov 6, 2025

Currently cosmetic (only low bits tested and they match)

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Currently cosmetic (only low bits tested and they match)
@yumkam yumkam marked this pull request as ready for review November 6, 2025 18:35
Copilot AI review requested due to automatic review settings November 6, 2025 18:35
@yumkam yumkam requested a review from a team as a code owner November 6, 2025 18:35
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

🟢 2025-11-06 18:35:26 UTC The validation of the Pull Request description is successful.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the HTTP gateway's stream handling code by correcting an incorrect libcurl constant used for pausing stream reception. The change replaces CURL_WRITEFUNC_PAUSE (which is not a valid constant for curl_easy_pause) with the correct CURLPAUSE_RECV constant.

  • Corrected the curl pause constant from CURL_WRITEFUNC_PAUSE to CURLPAUSE_RECV when stopping stream reception

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

2025-11-06 18:38:11 UTC Pre-commit check linux-x86_64-release-asan for e2f1a70 has started.
2025-11-06 18:38:28 UTC Artifacts will be uploaded here
2025-11-06 18:40:42 UTC ya make is running...
🟡 2025-11-06 21:01:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15727 15339 0 152 212 24

🟢 2025-11-06 21:02:12 UTC Build successful.
🟡 2025-11-06 21:02:40 UTC ydbd size 3.8 GiB changed* by +555.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0daa817 merge: e2f1a70 diff diff %
ydbd size 4 071 937 656 Bytes 4 072 506 800 Bytes +555.8 KiB +0.014%
ydbd stripped size 1 511 446 344 Bytes 1 511 693 096 Bytes +241.0 KiB +0.016%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

2025-11-06 18:39:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for e2f1a70 has started.
2025-11-06 18:40:05 UTC Artifacts will be uploaded here
2025-11-06 18:42:22 UTC ya make is running...
🟡 2025-11-06 20:32:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39326 36503 0 2 2793 28

2025-11-06 20:33:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-06 20:41:58 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59 (only retried tests) 44 0 0 0 15

🟢 2025-11-06 20:42:06 UTC Build successful.
🟡 2025-11-06 20:42:26 UTC ydbd size 2.3 GiB changed* by +263.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0daa817 merge: e2f1a70 diff diff %
ydbd size 2 431 199 208 Bytes 2 431 468 752 Bytes +263.2 KiB +0.011%
ydbd stripped size 516 413 392 Bytes 516 465 264 Bytes +50.7 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam merged commit f8c0b07 into ydb-platform:main Nov 8, 2025
19 checks passed
yumkam added a commit to yumkam/ydb that referenced this pull request Nov 11, 2025
yumkam added a commit to yumkam/ydb that referenced this pull request Nov 11, 2025
yumkam added a commit that referenced this pull request Nov 12, 2025
…l when we released inflight buffers (backport q-25-1 #28390) (#28660)
yumkam added a commit that referenced this pull request Nov 12, 2025
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants