clean inserted portions normalizer has been added #28406
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new normalizer TCleanInsertedPortionsNormalizer to clean inserted portions from the columnshard. The normalizer identifies portions with NPortion::EProduced::INSERTED status and marks them for removal by setting a remove snapshot.
- Adds new normalizer class
TCleanInsertedPortionsNormalizerfor cleaning inserted portions - Includes unit test infrastructure with
TInsertedPortionsCleanertest modifier - Alphabetically reorganizes the SRCS list in the build configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ydb/core/tx/columnshard/normalizer/portion/clean_inserted_portions.h | Header file defining the new TCleanInsertedPortionsNormalizer class |
| ydb/core/tx/columnshard/normalizer/portion/clean_inserted_portions.cpp | Implementation of the normalizer logic for cleaning inserted portions |
| ydb/core/tx/columnshard/normalizer/portion/ya.make | Adds the new source file and alphabetizes the source file list |
| ydb/core/tx/columnshard/ut_rw/ut_normalizer.cpp | Adds unit test for the new normalizer functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| virtual bool CheckPortion(const NColumnShard::TTablesManager& tablesManager, const TPortionDataAccessor& portionInfo) const override; | ||
| }; | ||
|
|
||
| } // namespace NKikimr::NOlap::NNormalizer::NBrokenBlobs |
There was a problem hiding this comment.
The namespace comment refers to 'NBrokenBlobs' but should refer to 'NCleanInsertedPortions' to match the namespace opened on line 12.
| } // namespace NKikimr::NOlap::NNormalizer::NBrokenBlobs | |
| } // namespace NKikimr::NOlap::NNormalizer::NCleanInsertedPortions |
| return true; | ||
| } | ||
|
|
||
| } // namespace NKikimr::NOlap::NNormalizer::NBrokenBlobs |
There was a problem hiding this comment.
The namespace comment refers to 'NBrokenBlobs' but should refer to 'NCleanInsertedPortions' to match the namespace opened on line 12.
| } // namespace NKikimr::NOlap::NNormalizer::NBrokenBlobs | |
| } // namespace NKikimr::NOlap::NNormalizer::NCleanInsertedPortions |
| Y_UNIT_TEST(InsertedPortionsCleanerNormalizer) { | ||
| class TLocalNormalizerChecker: public TNormalizerChecker { | ||
| public: | ||
| virtual ui64 RecordsCountAfterReboot(const ui64 /*initialRecodsCount*/) const override { |
There was a problem hiding this comment.
Corrected spelling of 'initialRecodsCount' to 'initialRecordsCount'.
|
🟢 |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
2 participants
Changelog entry
...
Changelog category
Description for reviewers
...