-
Notifications
You must be signed in to change notification settings - Fork 737
YQ-4735 Tests refactoring to unmute test #28454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🟢 |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the ExpectMessageBatch test helper function to support processing messages across multiple batches, improving test flexibility when dealing with message data that may be split across multiple events.
- The
ExpectMessageBatchfunction now acceptsTList<TRow>instead ofTBatchand loops to process multiple message batches - A new
expectNewDataArrivedparameter controls whether to wait for new data arrival events - Multiple test calls to
ExpectNewDataArrivedhave been removed, as they are now handled withinExpectMessageBatch
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ydb/core/fq/libs/row_dispatcher/ut/topic_session_ut.cpp | Refactored ExpectMessageBatch to handle multiple batches via loop; updated test cases to pass expectNewDataArrived parameter and removed redundant ExpectNewDataArrived calls |
| ydb/core/fq/libs/row_dispatcher/format_handler/ut/topic_parser_ut.cpp | Added new test SkipErrors1JsonIn2Messages to verify error handling when JSON is split across multiple messages |
| ydb/core/fq/libs/row_dispatcher/format_handler/ut/common/ut_common.h | Added iterator-based constructor to TBatch class to support creating batches from iterator ranges |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/core/fq/libs/row_dispatcher/format_handler/ut/common/ut_common.h
Outdated
Show resolved
Hide resolved
…mmon.h Co-authored-by: Pisarenko Grigoriy <grigoriypisar@ydb.tech>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Co-authored-by: Pisarenko Grigoriy <grigoriypisar@ydb.tech> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Changelog entry
...
Changelog category
Description for reviewers
...