Skip to content

Conversation

@kardymonds
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copilot AI review requested due to automatic review settings November 10, 2025 08:23
@kardymonds kardymonds requested a review from a team as a code owner November 10, 2025 08:23
@github-actions
Copy link

🟢 2025-11-10 08:25:18 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

2025-11-10 08:27:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6c9a8de has started.
2025-11-10 08:27:16 UTC Artifacts will be uploaded here
2025-11-10 08:29:31 UTC ya make is running...
🟢 2025-11-10 08:32:37 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
88 88 0 0 0 0

🟢 2025-11-10 08:32:47 UTC Build successful.
🟢 2025-11-10 08:33:02 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 56f5415 merge: 6c9a8de diff diff %
ydbd size 2 437 268 264 Bytes 2 437 268 264 Bytes 0 Bytes 0.000%
ydbd stripped size 518 550 160 Bytes 518 550 160 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

2025-11-10 08:27:00 UTC Pre-commit check linux-x86_64-release-asan for 6c9a8de has started.
2025-11-10 08:27:18 UTC Artifacts will be uploaded here
2025-11-10 08:29:31 UTC ya make is running...
🟢 2025-11-10 08:33:16 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
88 88 0 0 0 0

🟢 2025-11-10 08:33:27 UTC Build successful.
🟢 2025-11-10 08:33:45 UTC ydbd size 3.8 GiB changed* by +13.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7665309 merge: 6c9a8de diff diff %
ydbd size 4 080 330 048 Bytes 4 080 343 696 Bytes +13.3 KiB +0.000%
ydbd stripped size 1 514 658 312 Bytes 1 514 662 792 Bytes +4.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the ExpectMessageBatch test helper function to support processing messages across multiple batches, improving test flexibility when dealing with message data that may be split across multiple events.

  • The ExpectMessageBatch function now accepts TList<TRow> instead of TBatch and loops to process multiple message batches
  • A new expectNewDataArrived parameter controls whether to wait for new data arrival events
  • Multiple test calls to ExpectNewDataArrived have been removed, as they are now handled within ExpectMessageBatch

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
ydb/core/fq/libs/row_dispatcher/ut/topic_session_ut.cpp Refactored ExpectMessageBatch to handle multiple batches via loop; updated test cases to pass expectNewDataArrived parameter and removed redundant ExpectNewDataArrived calls
ydb/core/fq/libs/row_dispatcher/format_handler/ut/topic_parser_ut.cpp Added new test SkipErrors1JsonIn2Messages to verify error handling when JSON is split across multiple messages
ydb/core/fq/libs/row_dispatcher/format_handler/ut/common/ut_common.h Added iterator-based constructor to TBatch class to support creating batches from iterator ranges

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

2025-11-10 08:43:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for eaa8284 has started.
2025-11-10 08:43:08 UTC Artifacts will be uploaded here
2025-11-10 08:44:40 UTC ya make is running...
🟢 2025-11-10 08:47:56 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
88 88 0 0 0 0

🟢 2025-11-10 08:48:05 UTC Build successful.
🟢 2025-11-10 08:48:19 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 56f5415 merge: eaa8284 diff diff %
ydbd size 2 437 268 264 Bytes 2 437 268 264 Bytes 0 Bytes 0.000%
ydbd stripped size 518 550 160 Bytes 518 550 160 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

2025-11-10 08:43:24 UTC Pre-commit check linux-x86_64-release-asan for eaa8284 has started.
2025-11-10 08:43:41 UTC Artifacts will be uploaded here
2025-11-10 08:45:58 UTC ya make is running...
🟢 2025-11-10 08:49:56 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
88 88 0 0 0 0

🟢 2025-11-10 08:50:06 UTC Build successful.
🟢 2025-11-10 08:50:23 UTC ydbd size 3.8 GiB changed* by +13.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7665309 merge: eaa8284 diff diff %
ydbd size 4 080 330 048 Bytes 4 080 343 696 Bytes +13.3 KiB +0.000%
ydbd stripped size 1 514 658 312 Bytes 1 514 662 792 Bytes +4.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

GrigoriyPA
GrigoriyPA previously approved these changes Nov 10, 2025
…mmon.h

Co-authored-by: Pisarenko Grigoriy <grigoriypisar@ydb.tech>
kardymonds and others added 3 commits November 10, 2025 19:58
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

2025-11-10 17:01:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for a9dfd6c has started.
2025-11-10 17:02:04 UTC Artifacts will be uploaded here
2025-11-10 17:04:22 UTC ya make is running...
🟢 2025-11-10 17:07:23 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
88 88 0 0 0 0

🟢 2025-11-10 17:07:31 UTC Build successful.
🟢 2025-11-10 17:07:45 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 55b2fbd merge: a9dfd6c diff diff %
ydbd size 2 437 459 536 Bytes 2 437 459 536 Bytes 0 Bytes 0.000%
ydbd stripped size 518 602 768 Bytes 518 602 768 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

2025-11-10 17:02:18 UTC Pre-commit check linux-x86_64-release-asan for a9dfd6c has started.
2025-11-10 17:02:34 UTC Artifacts will be uploaded here
2025-11-10 17:04:39 UTC ya make is running...
🟢 2025-11-10 17:08:09 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
88 88 0 0 0 0

🟢 2025-11-10 17:08:17 UTC Build successful.
🟢 2025-11-10 17:08:35 UTC ydbd size 3.8 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 55b2fbd merge: a9dfd6c diff diff %
ydbd size 4 080 530 280 Bytes 4 080 530 184 Bytes -96 Bytes -0.000%
ydbd stripped size 1 514 729 768 Bytes 1 514 729 704 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kardymonds kardymonds merged commit e44a95b into ydb-platform:main Nov 12, 2025
11 checks passed
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
Co-authored-by: Pisarenko Grigoriy <grigoriypisar@ydb.tech>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants