Skip to content

Rename KtenantLeader key name to KtenantMaster in docs #28679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2025
Merged

Rename KtenantLeader key name to KtenantMaster in docs #28679

merged 1 commit into from
Nov 17, 2025

Conversation

@yurikiselev
Copy link
Collaborator

@yurikiselev yurikiselev commented Nov 12, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

@yurikiselev yurikiselev self-assigned this Nov 12, 2025
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

🟢 2025-11-12 05:10:10 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

⚪ 2025-11-12 05:12:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for cbd3da6 has started.
⚪ 2025-11-12 05:12:46 UTC Artifacts will be uploaded here
⚪ 2025-11-12 05:14:57 UTC ya make is running...
🟢 2025-11-12 05:15:03 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-12 05:15:08 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

⚪ 2025-11-12 05:13:03 UTC Pre-commit check linux-x86_64-release-asan for cbd3da6 has started.
⚪ 2025-11-12 05:13:20 UTC Artifacts will be uploaded here
⚪ 2025-11-12 05:15:29 UTC ya make is running...
🟢 2025-11-12 05:15:36 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-12 05:15:42 UTC Build successful.

@yurikiselev yurikiselev marked this pull request as ready for review November 12, 2025 05:57
Copilot AI review requested due to automatic review settings November 12, 2025 05:57
@yurikiselev yurikiselev enabled auto-merge (squash) November 12, 2025 05:57
Copilot finished reviewing on behalf of yurikiselev November 12, 2025 05:59
Copilot AI reviewed Nov 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the key name from KtenantLeader to KtenantMaster in the blob encryption v1 documentation GraphML file. This is a terminology update to align naming conventions across the encryption documentation.

  • Renamed KtenantLeader to KtenantMaster in two occurrences within the same node label

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yurikiselev yurikiselev force-pushed the fix-blob-encryption-key-naming-in-docs branch from 1204fd2 to d454f90 Compare November 12, 2025 07:12
@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

⚪ 2025-11-12 07:13:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for d8afcb9 has started.
⚪ 2025-11-12 07:14:01 UTC Artifacts will be uploaded here
⚪ 2025-11-12 07:16:54 UTC ya make is running...
🟢 2025-11-12 07:17:01 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-12 07:17:07 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

⚪ 2025-11-12 07:15:54 UTC Pre-commit check linux-x86_64-release-asan for d8afcb9 has started.
⚪ 2025-11-12 07:16:10 UTC Artifacts will be uploaded here
⚪ 2025-11-12 07:18:21 UTC ya make is running...
🟢 2025-11-12 07:18:28 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-12 07:18:33 UTC Build successful.

the-ancient-1
the-ancient-1 approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@the-ancient-1 the-ancient-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yurikiselev yurikiselev merged commit 98de507 into ydb-platform:main Nov 17, 2025
10 checks passed
@yurikiselev yurikiselev deleted the fix-blob-encryption-key-naming-in-docs branch November 17, 2025 09:09
@Enjection Enjection mentioned this pull request Nov 24, 2025
Merged
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
@yurikiselev @qyryq
Rename KtenantLeader key name to KtenantMaster in docs (ydb-platform#…
8a4317d 
…28679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@the-ancient-1 the-ancient-1 the-ancient-1 approved these changes

Assignees

@yurikiselev yurikiselev

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yurikiselev @the-ancient-1