Skip to content

Conversation

@dahbka-lis
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copilot AI review requested due to automatic review settings November 13, 2025 22:21
@dahbka-lis dahbka-lis requested a review from a team as a code owner November 13, 2025 22:21
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

2025-11-13 22:22:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0fc60bd has started.
2025-11-13 22:23:10 UTC Artifacts will be uploaded here
2025-11-13 22:25:26 UTC ya make is running...
🟡 2025-11-13 23:57:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41340 38518 0 3 2791 28

2025-11-13 23:58:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-14 00:10:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 (only retried tests) 40 0 1 0 17

2025-11-14 00:11:05 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-11-14 00:19:06 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
34 (only retried tests) 19 0 0 0 15

🟢 2025-11-14 00:19:12 UTC Build successful.
🟢 2025-11-14 00:19:34 UTC ydbd size 2.3 GiB changed* by +63.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fd5e49e merge: 0fc60bd diff diff %
ydbd size 2 479 688 152 Bytes 2 479 752 776 Bytes +63.1 KiB +0.003%
ydbd stripped size 521 082 480 Bytes 521 096 688 Bytes +13.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

2025-11-13 22:23:11 UTC Pre-commit check linux-x86_64-release-asan for 0fc60bd has started.
2025-11-13 22:23:28 UTC Artifacts will be uploaded here
2025-11-13 22:25:47 UTC ya make is running...
🟡 2025-11-14 00:41:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17706 17184 0 264 227 31

🟢 2025-11-14 00:41:47 UTC Build successful.
🟡 2025-11-14 00:42:15 UTC ydbd size 3.9 GiB changed* by +102.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fd5e49e merge: 0fc60bd diff diff %
ydbd size 4 136 091 160 Bytes 4 136 196 416 Bytes +102.8 KiB +0.003%
ydbd stripped size 1 522 849 256 Bytes 1 522 889 128 Bytes +38.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

🟢 2025-11-13 22:24:23 UTC The validation of the Pull Request description is successful.

Copilot finished reviewing on behalf of dahbka-lis November 13, 2025 22:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unnecessary bytes counters for batch operations and improves error handling and logging throughout the KQP partitioned executer. The changes focus on making the code more maintainable and providing better observability during batch operation execution.

Key changes:

  • Removed BatchOperationUpdateBytes and BatchOperationDeleteBytes counters across the codebase
  • Refactored error handling from RuntimeError to AbortWithError with improved state management
  • Enhanced logging with more detailed context (partition indices, actor IDs) and appropriate log levels

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
ydb/core/kqp/executer_actor/kqp_partitioned_executer.cpp Major refactoring of error handling (RuntimeError → AbortWithError), improved logging with partition/actor context, and better state management in AbortState
ydb/core/kqp/executer_actor/kqp_executer_impl.h Removed bytes counter updates for batch operations (UpdateBytes, DeleteBytes)
ydb/core/kqp/counters/kqp_counters.h Removed bytes counter declarations for batch operations
ydb/core/kqp/counters/kqp_counters.cpp Removed bytes counter initialization for batch operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dahbka-lis dahbka-lis enabled auto-merge (squash) November 13, 2025 22:58
@dahbka-lis dahbka-lis merged commit d8438d3 into ydb-platform:main Nov 14, 2025
18 checks passed
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Nov 14, 2025
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Nov 14, 2025
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Nov 14, 2025
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Nov 14, 2025
@dahbka-lis dahbka-lis linked an issue Nov 14, 2025 that may be closed by this pull request
dahbka-lis added a commit that referenced this pull request Nov 14, 2025
dahbka-lis added a commit that referenced this pull request Nov 14, 2025
maybenotilya pushed a commit to maybenotilya/ydb that referenced this pull request Nov 15, 2025
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some bugs with BATCH operations after enabling, /ru-prestable

2 participants