-
Notifications
You must be signed in to change notification settings - Fork 735
Remove bytes counters, fix issues returning and logs for BATCH operations #28853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bytes counters, fix issues returning and logs for BATCH operations #28853
Conversation
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes unnecessary bytes counters for batch operations and improves error handling and logging throughout the KQP partitioned executer. The changes focus on making the code more maintainable and providing better observability during batch operation execution.
Key changes:
- Removed
BatchOperationUpdateBytesandBatchOperationDeleteBytescounters across the codebase - Refactored error handling from
RuntimeErrortoAbortWithErrorwith improved state management - Enhanced logging with more detailed context (partition indices, actor IDs) and appropriate log levels
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb/core/kqp/executer_actor/kqp_partitioned_executer.cpp | Major refactoring of error handling (RuntimeError → AbortWithError), improved logging with partition/actor context, and better state management in AbortState |
| ydb/core/kqp/executer_actor/kqp_executer_impl.h | Removed bytes counter updates for batch operations (UpdateBytes, DeleteBytes) |
| ydb/core/kqp/counters/kqp_counters.h | Removed bytes counter declarations for batch operations |
| ydb/core/kqp/counters/kqp_counters.cpp | Removed bytes counter initialization for batch operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changelog entry
...
Changelog category
Description for reviewers
...